[GitHub] geode-native issue #21: GEODE-2441: Remove pdx auto serializer from core sou...

[davinash]

Github user davinash commented on the issue:

https://github.com/apache/geode-native/pull/21
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2441) Remove PDXAutoSerializer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878107#comment-15878107
 ] 

ASF GitHub Bot commented on GEODE-2441:
---

Github user davinash commented on the issue:

https://github.com/apache/geode-native/pull/21
  
LGTM


> Remove PDXAutoSerializer 
> -
>
> Key: GEODE-2441
> URL: https://issues.apache.org/jira/browse/GEODE-2441
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> Remove PDXAutoSerializer utility that generates PDX serialization C++ source 
> that you can include in your project to (de)serialize your C++ classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: for discussion: separate website into its own repo

[Anthony Baker]

> On Feb 17, 2017, at 1:15 PM, Karen Miller  wrote:
> 
> Seems like everyone is in favor of the separate repo.  I'll request one
> early next week.
> I created https://issues.apache.org/jira/browse/GEODE-2507 to handle the
> first parts
> of the task of getting the new repo up and running.
> 

The new repo is up and running (thanks Karen!).  Please review the contents and 
give a shout if you have a suggestion or something is awry.  INFRA is currently 
setting up travis-ci integration 
(https://issues.apache.org/jira/browse/INFRA-13562).  This will only do rat 
checks at this point.

I think we are ready to switch the geode website publishing over to the 
geode-site repo.  Barring objections, I’ll file an INFRA ticket for this in a 
day or so.

Still to do:  
- update the README.md in the project root.
- can we remove build.sh / run.sh?  These seem fairly useless

Anthony

[jira] [Commented] (GEODE-2516) Script to Run Quickstarts not exectable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878519#comment-15878519
 ] 

ASF GitHub Bot commented on GEODE-2516:
---

GitHub user mmartell opened a pull request:

https://github.com/apache/geode-native/pull/22

GEODE-2516: Fix quickstart install to retain permissions.

- By default cmake install unsets the execute bit. To retain it add 
USE_SOURCE_PERMISSIONS flag.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mmartell/geode-native feature/GEODE-2516

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22


commit f27ea86ff04062073c7ebbd01b9f19f349797456
Author: Mike Martell 
Date:   2017-02-22T15:46:38Z

GEODE-2516: Fix quickstart install to retain permissions.

- By default cmake install unsets the execute bit. To retain it add 
USE_SOURCE_PERMISSIONS flag.




> Script to Run Quickstarts not exectable
> ---
>
> Key: GEODE-2516
> URL: https://issues.apache.org/jira/browse/GEODE-2516
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Martell
>
> The runcpp.sh script for running the native client quickstarts is not 
> executable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #22: GEODE-2516: Fix quickstart install to retain ...

[mmartell]

GitHub user mmartell opened a pull request:

https://github.com/apache/geode-native/pull/22

GEODE-2516: Fix quickstart install to retain permissions.

- By default cmake install unsets the execute bit. To retain it add 
USE_SOURCE_PERMISSIONS flag.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mmartell/geode-native feature/GEODE-2516

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22


commit f27ea86ff04062073c7ebbd01b9f19f349797456
Author: Mike Martell 
Date:   2017-02-22T15:46:38Z

GEODE-2516: Fix quickstart install to retain permissions.

- By default cmake install unsets the execute bit. To retain it add 
USE_SOURCE_PERMISSIONS flag.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #756

[Apache Jenkins Server]

See 


Changes:

[upthewaterspout] GEODE-2029 Trimming unused parts of Lucene from binary NOTICE

--
[...truncated 98.33 KB...]

org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest > 
testSystemClientEventsInServer FAILED
org.junit.ComparisonFailure: 
expected:<[67.195.81.13]9(25592):32...> but 
was:<[asf91]9(25592):32...>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.doTestSystemClientEventsInServer(UniversalMembershipListenerAdapterDUnitTest.java:946)
at 
org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.testSystemClientEventsInServer(UniversalMembershipListenerAdapterDUnitTest.java:731)

6854 tests completed, 1 failed, 605 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources UP-TO-DATE
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble

[jira] [Resolved] (GEODE-2516) Script to Run Quickstarts not exectable

[Michael Martell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Martell resolved GEODE-2516.

Resolution: Fixed

> Script to Run Quickstarts not exectable
> ---
>
> Key: GEODE-2516
> URL: https://issues.apache.org/jira/browse/GEODE-2516
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Martell
>
> The runcpp.sh script for running the native client quickstarts is not 
> executable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #402: GEODE-2497 surprise members are never timed out dur...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/402


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878640#comment-15878640
 ] 

ASF GitHub Bot commented on GEODE-2497:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/402


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878637#comment-15878637
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 135bd77a11c10609310838bb77cf9bb57d38fee3 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=135bd77 ]

GEODE-2497 surprise members are never timed out during startup

Merge of 8d45ca22737282abe279d3c863478f904f2e1926 and
a6dfa4ca630a82fcf92942a834f8255e86d2bfcb from feature/GEODE-2497.

Moved the creation of the timer to GMSMembershipManager.started()

Removed write-lock in timer-creation method since it's only called from
one place now

Altered the way that the timer-creation method finds the
InternalDistributedSystem.  The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.

Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.

Altered the surprise-member unit test to run faster.  It now completes in
under 10 seconds.

This closes #402


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878638#comment-15878638
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 135bd77a11c10609310838bb77cf9bb57d38fee3 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=135bd77 ]

GEODE-2497 surprise members are never timed out during startup

Merge of 8d45ca22737282abe279d3c863478f904f2e1926 and
a6dfa4ca630a82fcf92942a834f8255e86d2bfcb from feature/GEODE-2497.

Moved the creation of the timer to GMSMembershipManager.started()

Removed write-lock in timer-creation method since it's only called from
one place now

Altered the way that the timer-creation method finds the
InternalDistributedSystem.  The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.

Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.

Altered the surprise-member unit test to run faster.  It now completes in
under 10 seconds.

This closes #402


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878639#comment-15878639
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 3474fa7ab4bccbe7a08f70e251ac778eebd6c453 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3474fa7 ]

GEODE-2497 surprise member not removed during startup

addressing Galen's comments on the pull request


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878697#comment-15878697
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 8065b67292049adf6027694d744eff43253aba92 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8065b67 ]

GEODE-2497 removing spots


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #23: GEODE-2478: Replace gf with geode.

[PivotalSarge]

GitHub user PivotalSarge opened a pull request:

https://github.com/apache/geode-native/pull/23

GEODE-2478: Replace gf with geode.

- Rename directories and files with gf into their name to
  instead use geode and update all references thereto.
- Ensure formatting style guide compliance.
- Elide duplicate GEODE_ from include guards.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PivotalSarge/geode-native feature/GEODE-2478

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #23


commit a58b1440b76a3d693e720ce72b6cd18a26fbc8c0
Author: Sarge 
Date:   2017-02-22T03:41:10Z

GEODE-2478: Replace gf with geode.

- Rename directories and files with gf into their name to
  instead use geode and update all references thereto.
- Ensure formatting style guide compliance.
- Elide duplicate GEODE_ from include guards.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #19: GEODE-2508: Inital work on making lib names g...

[echobravopapa]

Github user echobravopapa closed the pull request at:

https://github.com/apache/geode-native/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #19: GEODE-2508: Inital work on making lib names generic.

[echobravopapa]

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/19
  
Closing to take different approach.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2508) Generize lib naming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878703#comment-15878703
 ] 

ASF GitHub Bot commented on GEODE-2508:
---

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/19
  
Closing to take different approach.


> Generize lib naming
> ---
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Ernest Burghardt
>
> Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2497) surprise members are never timed out during startup

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt resolved GEODE-2497.
-
   Resolution: Fixed
Fix Version/s: 1.2.0

> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2478) Replace gf with geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878701#comment-15878701
 ] 

ASF GitHub Bot commented on GEODE-2478:
---

GitHub user PivotalSarge opened a pull request:

https://github.com/apache/geode-native/pull/23

GEODE-2478: Replace gf with geode.

- Rename directories and files with gf into their name to
  instead use geode and update all references thereto.
- Ensure formatting style guide compliance.
- Elide duplicate GEODE_ from include guards.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PivotalSarge/geode-native feature/GEODE-2478

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #23


commit a58b1440b76a3d693e720ce72b6cd18a26fbc8c0
Author: Sarge 
Date:   2017-02-22T03:41:10Z

GEODE-2478: Replace gf with geode.

- Rename directories and files with gf into their name to
  instead use geode and update all references thereto.
- Ensure formatting style guide compliance.
- Elide duplicate GEODE_ from include guards.




> Replace gf with geode
> -
>
> Key: GEODE-2478
> URL: https://issues.apache.org/jira/browse/GEODE-2478
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>
> The substring "gf" still occurs in some places in the native client codebase. 
> It ought to be replaced with "geode" or "geode-native", whichever makes more 
> sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...

[echobravopapa]

GitHub user echobravopapa opened a pull request:

https://github.com/apache/geode-native/pull/24

GEODE-2508: Initial work on new approach to generic lib naming.

Keeping the changes to CppCacheLibrary.cpp - did not, yet, find a CMake way 
to do it more seamlessly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/echobravopapa/geode-native feature/GEODE-2508

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit c3936e60af42b8a7287ac3554b73f0d6892ef764
Author: Ernest Burghardt 
Date:   2017-02-22T16:52:13Z

GEODE-2508: Initial work on new approach to generic lib naming.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2508) Generize lib naming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878712#comment-15878712
 ] 

ASF GitHub Bot commented on GEODE-2508:
---

GitHub user echobravopapa opened a pull request:

https://github.com/apache/geode-native/pull/24

GEODE-2508: Initial work on new approach to generic lib naming.

Keeping the changes to CppCacheLibrary.cpp - did not, yet, find a CMake way 
to do it more seamlessly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/echobravopapa/geode-native feature/GEODE-2508

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit c3936e60af42b8a7287ac3554b73f0d6892ef764
Author: Ernest Burghardt 
Date:   2017-02-22T16:52:13Z

GEODE-2508: Initial work on new approach to generic lib naming.




> Generize lib naming
> ---
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Ernest Burghardt
>
> Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2508) Generize lib naming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878704#comment-15878704
 ] 

ASF GitHub Bot commented on GEODE-2508:
---

Github user echobravopapa closed the pull request at:

https://github.com/apache/geode-native/pull/19


> Generize lib naming
> ---
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Ernest Burghardt
>
> Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2461:
-
Description: 
These unused entries are potential candidates for removal from 
gradle/dependency-versions.properties:

* hadoop.version*
* hbase.version
* hibernate.version
* hibernate-commons-annotations.version
* hsqldb.version
* jline.version
* jsr305.version
* paranamer.version
* quartz.version

  was:
These are potential candidates for removal from explicit inclusion in 
gradle/dependency-versions.properties:

* hadoop
* hsqldb



> Remove unnecessary entries from gradle/dependency-versions.properties
> -
>
> Key: GEODE-2461
> URL: https://issues.apache.org/jira/browse/GEODE-2461
> Project: Geode
>  Issue Type: Wish
>  Components: build
>Reporter: Kirk Lund
>
> These unused entries are potential candidates for removal from 
> gradle/dependency-versions.properties:
> * hadoop.version*
> * hbase.version
> * hibernate.version
> * hibernate-commons-annotations.version
> * hsqldb.version
> * jline.version
> * jsr305.version
> * paranamer.version
> * quartz.version



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #24: GEODE-2508: Initial work on new approach to generic ...

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/24
  
@PivotalSarge yes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (GEODE-2520) Add a lucene query test where a bucket is moved while a query is executing

[Jason Huynh (JIRA)]

Jason Huynh created GEODE-2520:
--

 Summary: Add a lucene query test where a bucket is moved while a 
query is executing
 Key: GEODE-2520
 URL: https://issues.apache.org/jira/browse/GEODE-2520
 Project: Geode
  Issue Type: Bug
  Components: lucene
Reporter: Jason Huynh


The query should handle this scenario and return the correct results.

As currently implemented, it should end up retrying the query on the new 
primary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2508) Generize lib naming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878736#comment-15878736
 ] 

ASF GitHub Bot commented on GEODE-2508:
---

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/24
  
@PivotalSarge yes.


> Generize lib naming
> ---
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Ernest Burghardt
>
> Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2520) Add a lucene query test where a bucket is moved while a query is executing

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh updated GEODE-2520:
---
Issue Type: Test  (was: Bug)

> Add a lucene query test where a bucket is moved while a query is executing
> --
>
> Key: GEODE-2520
> URL: https://issues.apache.org/jira/browse/GEODE-2520
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>
> The query should handle this scenario and return the correct results.
> As currently implemented, it should end up retrying the query on the new 
> primary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2520) Add a lucene query test where a bucket is moved while a query is executing

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh updated GEODE-2520:
---
Affects Version/s: 1.0.0-incubating

> Add a lucene query test where a bucket is moved while a query is executing
> --
>
> Key: GEODE-2520
> URL: https://issues.apache.org/jira/browse/GEODE-2520
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>
> The query should handle this scenario and return the correct results.
> As currently implemented, it should end up retrying the query on the new 
> primary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2520) Add a lucene query test where a bucket is moved while a query is executing

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh reassigned GEODE-2520:
--

Assignee: Jason Huynh

> Add a lucene query test where a bucket is moved while a query is executing
> --
>
> Key: GEODE-2520
> URL: https://issues.apache.org/jira/browse/GEODE-2520
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> The query should handle this scenario and return the correct results.
> As currently implemented, it should end up retrying the query on the new 
> primary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 56933: Attempt to refactor the Lucene DUnit tests

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56933/
---

Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, Dan 
Smith, and xiaojian zhou.


Repository: geode


Description
---

LuceneDUnitTest and LuceneQueriesAccessorBase are base type classes similar to 
the old LuceneDUnitTest and LuceneQueriesBase. 

Made the tests parameterized with a RegionTestableType enum.  This enum "knows" 
how to create a region provided a cache and a name.

Renamed the tests by functionality

Some of the refactoring is a bit clunky as some of our tests were expecting a 
different behavior with initDataStore based on the region type.  If it were not 
for that, 2 more classes could have been removed.

If this is ok, then we'd probably want to change the Integration tests to look 
similar.


Diffs
-

  geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
9318b0e 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java
 6a02a25 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationOnFixedPRDUnitTest.java
 7de12e3 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesAccessorBase.java
 PRE-CREATION 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesBase.java 
1b1167c 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesClientDUnitTest.java
 36ede16 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesDUnitTest.java
 PRE-CREATION 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java
 9c2f6ed 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerFixedPRDUnitTest.java
 2622063 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRDUnitTest.java
 f65777f 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java
 86ce713 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRPersistentDUnitTest.java
 4e809ce 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
 1b4303a 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceDUnitTest.java
 PRE-CREATION 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceWithRedundancyDUnitTest.java
 PRE-CREATION 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java
 5a6f774 

Diff: https://reviews.apache.org/r/56933/diff/


Testing
---


Thanks,

Jason Huynh

Review Request 56932: GEODE-2520:Add a lucene query test where a bucket is moved while a query is executing

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56932/
---

Review request for geode, nabarun nag, Dan Smith, and xiaojian zhou.


Repository: geode


Description
---

The query should continue to work if a bucket has moved mid query execution.

Added a spy to move a bucket when "getRepo(bucketId)" is called.


Diffs
-

  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java
 9d45526 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
 90f1b9f 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java
 931edc5 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
 496721a 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexFactorySpy.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56932/diff/


Testing
---


Thanks,

Jason Huynh

Review Request 56934: GEODE-2460: update dependency versions

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56934/
---

Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
Duling, Ken Howe, and Mark Bretl.


Bugs: GEODE-2460
https://issues.apache.org/jira/browse/GEODE-2460


Repository: geode


Description
---

-asm.version = 5.1
+asm.version = 5.2

-fastutil.version = 7.0.13
+fastutil.version = 7.1.0

-httpclient.version = 4.5.2
+httpclient.version = 4.5.3

-netty-all.version = 4.1.7.Final
-open-json.version = 1.7
+netty-all.version = 4.1.8.Final
+open-json.version = 1.8

-slf4j-api.version = 1.7.22
+slf4j-api.version = 1.7.23

-spring-hateoas.version = 0.21.0.RELEASE
+spring-hateoas.version = 0.23.0.RELEASE

-spring-ldap-core.version = 2.1.0.RELEASE
-spring-security.version = 4.1.3.RELEASE
-spring-tx.version = 4.3.2.RELEASE
-springframework.version = 4.3.2.RELEASE
+spring-ldap-core.version = 2.3.1.RELEASE
+spring-security.version = 4.2.1.RELEASE
+spring-tx.version = 4.3.6.RELEASE
+springframework.version = 4.3.6.RELEASE

-springfox.version=2.6.0
+springfox.version=2.6.1

I tried to update selenium.version from 3.0.1 to 3.1.0 but it results in uiTest 
failures so I backed that out and will file a separate Jira ticket for updating 
Selenium.


Diffs
-

  gradle/dependency-versions.properties 12a76b4 

Diff: https://reviews.apache.org/r/56934/diff/


Testing
---

precheckin passed 100% green


Thanks,

Kirk Lund

[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/24#discussion_r102517638
  
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
 $
 )
 add_dependencies(client-libraries apache-geode)
-set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}")
+set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}" OUTPUT_NAME ${PRODUCT_LIB_NAME} )
--- End diff --

I would only suggest avoiding long lines in the CMake files by putting each 
property on a new line.

```
set_target_properties(apache-geode PROPERTIES
PUBLIC_HEADER "${PUBLIC_HEADERS}"
OUTPUT_NAME ${PRODUCT_LIB_NAME})
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2508) Generize lib naming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878742#comment-15878742
 ] 

ASF GitHub Bot commented on GEODE-2508:
---

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/24#discussion_r102517638
  
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
 $
 )
 add_dependencies(client-libraries apache-geode)
-set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}")
+set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}" OUTPUT_NAME ${PRODUCT_LIB_NAME} )
--- End diff --

I would only suggest avoiding long lines in the CMake files by putting each 
property on a new line.

```
set_target_properties(apache-geode PROPERTIES
PUBLIC_HEADER "${PUBLIC_HEADERS}"
OUTPUT_NAME ${PRODUCT_LIB_NAME})
```


> Generize lib naming
> ---
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Ernest Burghardt
>
> Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2418) Add gfsh post execution handler to detect and download file URLs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878753#comment-15878753
 ] 

ASF subversion and git services commented on GEODE-2418:


Commit 4a700206973e72099550aefbf89e3f29f52daf54 in geode's branch 
refs/heads/feature/GEODE-2267 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=4a70020 ]

GEODE-2418: enable gfsh to download file from http connection


> Add gfsh post execution handler to detect and download file URLs
> 
>
> Key: GEODE-2418
> URL: https://issues.apache.org/jira/browse/GEODE-2418
> Project: Geode
>  Issue Type: Sub-task
>  Components: configuration, gfsh
>Reporter: Jared Stewart
>
> Rather than return the zip file contents in the 'export logs' command result 
> from a locator to a gfsh client, we will return a URL to the exported zip 
> file (GEODE-2417).  We need to write a gfsh post-execution handler (see 
> `org.apache.geode.management.internal.cli.commands.ExportImportClusterConfigurationCommands.ExportInterceptor`)
>  to extract the file URL from the result JSON and download that file via HTTP 
> onto the gfsh client's disk.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56932: GEODE-2520:Add a lucene query test where a bucket is moved while a query is executing

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56932/#review166375
---


Ship it!




Ship It!

- Dan Smith


On Feb. 22, 2017, 5:09 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56932/
> ---
> 
> (Updated Feb. 22, 2017, 5:09 p.m.)
> 
> 
> Review request for geode, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The query should continue to work if a bucket has moved mid query execution.
> 
> Added a spy to move a bucket when "getRepo(bucketId)" is called.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java
>  9d45526 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
>  90f1b9f 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java
>  931edc5 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
>  496721a 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexFactorySpy.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56932/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

[jira] [Commented] (GEODE-2267) Add gfsh command to export stat files

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878754#comment-15878754
 ] 

ASF subversion and git services commented on GEODE-2267:


Commit 112f26699414bda43acc4a29311135bbac875fd1 in geode's branch 
refs/heads/feature/GEODE-2267 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=112f266 ]

GEODE-2267: spotless


> Add gfsh command to export stat files
> -
>
> Key: GEODE-2267
> URL: https://issues.apache.org/jira/browse/GEODE-2267
> Project: Geode
>  Issue Type: New Feature
>  Components: configuration, gfsh
>Reporter: Diane Hardman
>Assignee: Kirk Lund
>  Labels: ExportClusterArtifacts, export, gfsh, logging, statistics
>
> We would like a single gfsh command to collect and export all logfiles and 
> stat files into a single package that will be returned to the gfsh client 
> machine. This package (zipfile) can then be saved and attached to emails and 
> Jira tickets to help evaluate the Geode cluster status.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878763#comment-15878763
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 135bd77a11c10609310838bb77cf9bb57d38fee3 in geode's branch 
refs/heads/feature/GEODE-2267 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=135bd77 ]

GEODE-2497 surprise members are never timed out during startup

Merge of 8d45ca22737282abe279d3c863478f904f2e1926 and
a6dfa4ca630a82fcf92942a834f8255e86d2bfcb from feature/GEODE-2497.

Moved the creation of the timer to GMSMembershipManager.started()

Removed write-lock in timer-creation method since it's only called from
one place now

Altered the way that the timer-creation method finds the
InternalDistributedSystem.  The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.

Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.

Altered the surprise-member unit test to run faster.  It now completes in
under 10 seconds.

This closes #402


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2029) Review NOTICE for Lucene

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878762#comment-15878762
 ] 

ASF subversion and git services commented on GEODE-2029:


Commit c6b941fd3baee0038a99630936597e429e1c086b in geode's branch 
refs/heads/feature/GEODE-2267 from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c6b941f ]

GEODE-2029 Trimming unused parts of Lucene from binary NOTICE

The lucene section of our NOTICE included some elements for jars that we
are not redistributing like some language specific analyzers and
stemmers. To reduce the burden on downstream projects, removing these
components from our NOTICE.

I did leave in the section on servlet-api, which appeared to come from
lucene, but in fact we do include servlet-api.jar in our binary
distribution.

Here are the specific notes on where stuff in the notice came from

icu4j,WordBreakTestUnicode - this is in  lucene-analyzers-icu.jar (we don't 
include)
junit - we're not distributing this jar
stempel - this is in lucene-analyzers-stempel (we don't include)
smartcn - this is in  lucene-analyzers-smartcn (we don't include)
kuromoji - this in in lucene-analyzers-kuromoji (we don't include)
Morfologik - this in in lucene-analyzers-morfologik (we don't include)


> Review NOTICE for Lucene
> 
>
> Key: GEODE-2029
> URL: https://issues.apache.org/jira/browse/GEODE-2029
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Anthony Baker
>Assignee: Dan Smith
> Fix For: 1.2.0
>
>
> See:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201610.mbox/%3cca53f203-bef1-4bdb-a8b3-313ab035c...@classsoftware.com%3e
> https://github.com/apache/lucene-solr/blob/master/lucene/NOTICE.txt
> We are only bundling a few components of Lucene (core, analyzers-common, 
> queryparser, queries) however we have included the full Lucene NOTICE 
> contents within our NOTICE file for the binary distribution 
> (geode-assembly/src/main/dist/NOTICE).  In order to reduce the burden on 
> downstream projects, we should trim down the included parts to only those we 
> need (e.g. morfologik is not bundled).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878766#comment-15878766
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 8065b67292049adf6027694d744eff43253aba92 in geode's branch 
refs/heads/feature/GEODE-2267 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8065b67 ]

GEODE-2497 removing spots


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878760#comment-15878760
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 0805036e81756e3d843f3227e94927a520a07946 in geode's branch 
refs/heads/feature/GEODE-2267 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0805036 ]

Revert "GEODE-2142: Removal of non-compliant org.json implementation."

This reverts commit b3ec80bc72fee3a40da297945a85d8df6c2a6460.


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2490) Tombstone messages are getting processed inline

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878761#comment-15878761
 ] 

ASF subversion and git services commented on GEODE-2490:


Commit 826bdbfe2ae2f4b3cd27760584684bc35e19e9b7 in geode's branch 
refs/heads/feature/GEODE-2267 from [~agingade]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=826bdbf ]

GEODE-2490: Avoid processing tombstone GC message in-line

Currently the tombstone message sent for replicas are getting
processed in-line instead of handing it to thread pool.
Based on the number of nodes in the cluster, this may take
long time to process, impacting other cache operation that
required to be processed in-line.

The change provided here enables tombstone messages to
be not processed in-line instead processed in separate
thread.


> Tombstone messages are getting processed inline
> ---
>
> Key: GEODE-2490
> URL: https://issues.apache.org/jira/browse/GEODE-2490
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>
> Tombstone:
> As part of consistency checking, when an entry is destroyed, the member 
> temporarily retains the entry to detect possible conflicts with operations 
> that have occurred. The retained entry is referred to as a tombstone.
> When tombstones are removed, tombstone messages are sent to region replicas; 
> and in case of Partitioned Region (PR) messages are also sent to peer region 
> nodes for client events.
> Currently the tombstone message sent for replicas are getting processed 
> in-line. Based on the number of nodes in the cluster, this may take long time 
> to process, impacting other cache operation that required to be processed 
> in-line. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2267) Add gfsh command to export stat files

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878768#comment-15878768
 ] 

ASF subversion and git services commented on GEODE-2267:


Commit 4b268859dda59c50bb77a4c586f8dee42f5e2785 in geode's branch 
refs/heads/feature/GEODE-2267 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=4b26885 ]

Merge branch 'develop' into GEODE-2267


> Add gfsh command to export stat files
> -
>
> Key: GEODE-2267
> URL: https://issues.apache.org/jira/browse/GEODE-2267
> Project: Geode
>  Issue Type: New Feature
>  Components: configuration, gfsh
>Reporter: Diane Hardman
>Assignee: Kirk Lund
>  Labels: ExportClusterArtifacts, export, gfsh, logging, statistics
>
> We would like a single gfsh command to collect and export all logfiles and 
> stat files into a single package that will be returned to the gfsh client 
> machine. This package (zipfile) can then be saved and attached to emails and 
> Jira tickets to help evaluate the Geode cluster status.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878764#comment-15878764
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 135bd77a11c10609310838bb77cf9bb57d38fee3 in geode's branch 
refs/heads/feature/GEODE-2267 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=135bd77 ]

GEODE-2497 surprise members are never timed out during startup

Merge of 8d45ca22737282abe279d3c863478f904f2e1926 and
a6dfa4ca630a82fcf92942a834f8255e86d2bfcb from feature/GEODE-2497.

Moved the creation of the timer to GMSMembershipManager.started()

Removed write-lock in timer-creation method since it's only called from
one place now

Altered the way that the timer-creation method finds the
InternalDistributedSystem.  The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.

Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.

Altered the surprise-member unit test to run faster.  It now completes in
under 10 seconds.

This closes #402


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878765#comment-15878765
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 3474fa7ab4bccbe7a08f70e251ac778eebd6c453 in geode's branch 
refs/heads/feature/GEODE-2267 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3474fa7 ]

GEODE-2497 surprise member not removed during startup

addressing Galen's comments on the pull request


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878759#comment-15878759
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 1253d7808e3d35d2d6868e98e1ccb5bfa1749e35 in geode's branch 
refs/heads/feature/GEODE-2267 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1253d78 ]

Revert "GEODE-2142: Spotless"

This reverts commit 2e3a88f7bc61796042140aa92b44390b9970b53e.


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878787#comment-15878787
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 2e3a88f7bc61796042140aa92b44390b9970b53e in geode's branch 
refs/heads/feature/GEODE-2460 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=2e3a88f ]

GEODE-2142: Spotless


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878790#comment-15878790
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 0805036e81756e3d843f3227e94927a520a07946 in geode's branch 
refs/heads/feature/GEODE-2460 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0805036 ]

Revert "GEODE-2142: Removal of non-compliant org.json implementation."

This reverts commit b3ec80bc72fee3a40da297945a85d8df6c2a6460.


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2490) Tombstone messages are getting processed inline

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878791#comment-15878791
 ] 

ASF subversion and git services commented on GEODE-2490:


Commit 826bdbfe2ae2f4b3cd27760584684bc35e19e9b7 in geode's branch 
refs/heads/feature/GEODE-2460 from [~agingade]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=826bdbf ]

GEODE-2490: Avoid processing tombstone GC message in-line

Currently the tombstone message sent for replicas are getting
processed in-line instead of handing it to thread pool.
Based on the number of nodes in the cluster, this may take
long time to process, impacting other cache operation that
required to be processed in-line.

The change provided here enables tombstone messages to
be not processed in-line instead processed in separate
thread.


> Tombstone messages are getting processed inline
> ---
>
> Key: GEODE-2490
> URL: https://issues.apache.org/jira/browse/GEODE-2490
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>
> Tombstone:
> As part of consistency checking, when an entry is destroyed, the member 
> temporarily retains the entry to detect possible conflicts with operations 
> that have occurred. The retained entry is referred to as a tombstone.
> When tombstones are removed, tombstone messages are sent to region replicas; 
> and in case of Partitioned Region (PR) messages are also sent to peer region 
> nodes for client events.
> Currently the tombstone message sent for replicas are getting processed 
> in-line. Based on the number of nodes in the cluster, this may take long time 
> to process, impacting other cache operation that required to be processed 
> in-line. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878788#comment-15878788
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 1253d7808e3d35d2d6868e98e1ccb5bfa1749e35 in geode's branch 
refs/heads/feature/GEODE-2460 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1253d78 ]

Revert "GEODE-2142: Spotless"

This reverts commit 2e3a88f7bc61796042140aa92b44390b9970b53e.


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2029) Review NOTICE for Lucene

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878792#comment-15878792
 ] 

ASF subversion and git services commented on GEODE-2029:


Commit c6b941fd3baee0038a99630936597e429e1c086b in geode's branch 
refs/heads/feature/GEODE-2460 from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c6b941f ]

GEODE-2029 Trimming unused parts of Lucene from binary NOTICE

The lucene section of our NOTICE included some elements for jars that we
are not redistributing like some language specific analyzers and
stemmers. To reduce the burden on downstream projects, removing these
components from our NOTICE.

I did leave in the section on servlet-api, which appeared to come from
lucene, but in fact we do include servlet-api.jar in our binary
distribution.

Here are the specific notes on where stuff in the notice came from

icu4j,WordBreakTestUnicode - this is in  lucene-analyzers-icu.jar (we don't 
include)
junit - we're not distributing this jar
stempel - this is in lucene-analyzers-stempel (we don't include)
smartcn - this is in  lucene-analyzers-smartcn (we don't include)
kuromoji - this in in lucene-analyzers-kuromoji (we don't include)
Morfologik - this in in lucene-analyzers-morfologik (we don't include)


> Review NOTICE for Lucene
> 
>
> Key: GEODE-2029
> URL: https://issues.apache.org/jira/browse/GEODE-2029
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Anthony Baker
>Assignee: Dan Smith
> Fix For: 1.2.0
>
>
> See:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201610.mbox/%3cca53f203-bef1-4bdb-a8b3-313ab035c...@classsoftware.com%3e
> https://github.com/apache/lucene-solr/blob/master/lucene/NOTICE.txt
> We are only bundling a few components of Lucene (core, analyzers-common, 
> queryparser, queries) however we have included the full Lucene NOTICE 
> contents within our NOTICE file for the binary distribution 
> (geode-assembly/src/main/dist/NOTICE).  In order to reduce the burden on 
> downstream projects, we should trim down the included parts to only those we 
> need (e.g. morfologik is not bundled).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878796#comment-15878796
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 8065b67292049adf6027694d744eff43253aba92 in geode's branch 
refs/heads/feature/GEODE-2460 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8065b67 ]

GEODE-2497 removing spots


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878795#comment-15878795
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 3474fa7ab4bccbe7a08f70e251ac778eebd6c453 in geode's branch 
refs/heads/feature/GEODE-2460 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3474fa7 ]

GEODE-2497 surprise member not removed during startup

addressing Galen's comments on the pull request


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878793#comment-15878793
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 135bd77a11c10609310838bb77cf9bb57d38fee3 in geode's branch 
refs/heads/feature/GEODE-2460 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=135bd77 ]

GEODE-2497 surprise members are never timed out during startup

Merge of 8d45ca22737282abe279d3c863478f904f2e1926 and
a6dfa4ca630a82fcf92942a834f8255e86d2bfcb from feature/GEODE-2497.

Moved the creation of the timer to GMSMembershipManager.started()

Removed write-lock in timer-creation method since it's only called from
one place now

Altered the way that the timer-creation method finds the
InternalDistributedSystem.  The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.

Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.

Altered the surprise-member unit test to run faster.  It now completes in
under 10 seconds.

This closes #402


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878794#comment-15878794
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 135bd77a11c10609310838bb77cf9bb57d38fee3 in geode's branch 
refs/heads/feature/GEODE-2460 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=135bd77 ]

GEODE-2497 surprise members are never timed out during startup

Merge of 8d45ca22737282abe279d3c863478f904f2e1926 and
a6dfa4ca630a82fcf92942a834f8255e86d2bfcb from feature/GEODE-2497.

Moved the creation of the timer to GMSMembershipManager.started()

Removed write-lock in timer-creation method since it's only called from
one place now

Altered the way that the timer-creation method finds the
InternalDistributedSystem.  The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.

Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.

Altered the surprise-member unit test to run faster.  It now completes in
under 10 seconds.

This closes #402


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878812#comment-15878812
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 135bd77a11c10609310838bb77cf9bb57d38fee3 in geode's branch 
refs/heads/feature/GEODE-2514 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=135bd77 ]

GEODE-2497 surprise members are never timed out during startup

Merge of 8d45ca22737282abe279d3c863478f904f2e1926 and
a6dfa4ca630a82fcf92942a834f8255e86d2bfcb from feature/GEODE-2497.

Moved the creation of the timer to GMSMembershipManager.started()

Removed write-lock in timer-creation method since it's only called from
one place now

Altered the way that the timer-creation method finds the
InternalDistributedSystem.  The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.

Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.

Altered the surprise-member unit test to run faster.  It now completes in
under 10 seconds.

This closes #402


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878811#comment-15878811
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 135bd77a11c10609310838bb77cf9bb57d38fee3 in geode's branch 
refs/heads/feature/GEODE-2514 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=135bd77 ]

GEODE-2497 surprise members are never timed out during startup

Merge of 8d45ca22737282abe279d3c863478f904f2e1926 and
a6dfa4ca630a82fcf92942a834f8255e86d2bfcb from feature/GEODE-2497.

Moved the creation of the timer to GMSMembershipManager.started()

Removed write-lock in timer-creation method since it's only called from
one place now

Altered the way that the timer-creation method finds the
InternalDistributedSystem.  The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.

Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.

Altered the surprise-member unit test to run faster.  It now completes in
under 10 seconds.

This closes #402


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878814#comment-15878814
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 8065b67292049adf6027694d744eff43253aba92 in geode's branch 
refs/heads/feature/GEODE-2514 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8065b67 ]

GEODE-2497 removing spots


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2514) Need more tests for statistics archive rolling and removal

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878815#comment-15878815
 ] 

ASF subversion and git services commented on GEODE-2514:


Commit 7e85e08e0d5cc4a65c98270ea253e5e7331ca81e in geode's branch 
refs/heads/feature/GEODE-2514 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=7e85e08 ]

GEODE-2514: add new tests for statistics archive rolling and removal

* add MainWithChildrenRollingFileHandlerIntegrationTest
* add StatArchiveHandlerIntegrationTest
* expand DiskSpaceLimitIntegrationTest


> Need more tests for statistics archive rolling and removal
> --
>
> Key: GEODE-2514
> URL: https://issues.apache.org/jira/browse/GEODE-2514
> Project: Geode
>  Issue Type: Wish
>  Components: statistics
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> We need more integration tests for StatArchiveHandler and 
> MainWithChildrenRollingFileHandler with file system behavior for rolling and 
> removal.
> Rolling is controlled by archive-file-size-limit. Removal is controlled by 
> archive-disk-space-limit.
> Tests should involve the mainId and childId (-01-01) and how they roll. Tests 
> should also involve the marker file used by 
> MainWithChildrenRollingFileHandler.
> Some of the methods that we would like to test in isolation will need to be 
> changed from private to protected (or package private).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878813#comment-15878813
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 3474fa7ab4bccbe7a08f70e251ac778eebd6c453 in geode's branch 
refs/heads/feature/GEODE-2514 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3474fa7 ]

GEODE-2497 surprise member not removed during startup

addressing Galen's comments on the pull request


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #404: Geode 2469

[ggreen]

Github user ggreen commented on the issue:

https://github.com/apache/geode/pull/404
  
Hello,
Sorry about that.
It is there now
geode/SetExecutor.java at GEODE-2469 · ggreen/geode · GitHub

  
|  
|   
|   
|   ||

   |

  |
|  
||  
geode/SetExecutor.java at GEODE-2469 · ggreen/geode · GitHub
 geode - Mirror of Apache Geode  |   |

  |

  |

 

 

On Wednesday, February 22, 2017 12:21 PM, Bruce Schuchardt 
 wrote:
 

 @bschuchardt requested changes on this pull request.Hi ggreen, would you 
update the PR to include the missing SetInterpreter class?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.  

   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2469) Redis adapter Hash key support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878873#comment-15878873
 ] 

ASF GitHub Bot commented on GEODE-2469:
---

Github user ggreen commented on the issue:

https://github.com/apache/geode/pull/404
  
Hello,
Sorry about that.
It is there now
geode/SetExecutor.java at GEODE-2469 · ggreen/geode · GitHub

  
|  
|   
|   
|   ||

   |

  |
|  
||  
geode/SetExecutor.java at GEODE-2469 · ggreen/geode · GitHub
 geode - Mirror of Apache Geode  |   |

  |

  |

 

 

On Wednesday, February 22, 2017 12:21 PM, Bruce Schuchardt 
 wrote:
 

 @bschuchardt requested changes on this pull request.Hi ggreen, would you 
update the PR to include the missing SetInterpreter class?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.  

   


> Redis adapter Hash key support
> --
>
> Key: GEODE-2469
> URL: https://issues.apache.org/jira/browse/GEODE-2469
> Project: Geode
>  Issue Type: Sub-task
>  Components: redis
>Reporter: Gregory Green
>Assignee: Hitesh Khamesra
>
> The Redis adapter does not appear to handle hash keys correctly.
> The following Example: Redis CLI works.
> localhost:11211>  HSET companies name "John Smith"
> Using a  HSET :id  .. produces an error
> Example:
> localhost:11211>  HSET companies:1000 name "John Smith"
> [Server error]
> [fine 2017/02/10 16:04:33.289 EST server1  
> tid=0x6a] Region names may only be alphanumeric and may contain hyphens or 
> underscores: companies: 1000
> java.lang.IllegalArgumentException: Region names may only be alphanumeric and 
> may contain hyphens or underscores: companies: 1000
> at 
> org.apache.geode.internal.cache.LocalRegion.validateRegionName(LocalRegion.java:7618)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.createVMRegion(GemFireCacheImpl.java:3201)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreateRegion(GemFireCacheImpl.java:3181)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.createRegion(GemFireCacheImpl.java:3169)
> at org.apache.geode.cache.RegionFactory.create(RegionFactory.java:762)
> at 
> org.apache.geode.management.internal.cli.functions.RegionCreateFunction.createRegion(RegionCreateFunction.java:355)
> at 
> org.apache.geode.management.internal.cli.functions.RegionCreateFunction.execute(RegionCreateFunction.java:90)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.executeFunctionLocally(AbstractExecution.java:333)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution$2.run(AbstractExecution.java:303)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at 
> org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:621)
> at 
> org.apache.geode.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1067)
> at java.lang.Thread.run(Thread.java:745)
> //Example Spring Data Redis Object sample
> @Data
> @EqualsAndHashCode()
> @RedisHash(value="companies")
> @NoArgsConstructor
> public class Company
> {
>   private @Id String id;
>
> //Repository
> public interface CompanyRepository extends CrudRepository 
> {
>  
> }
> //When saving using a repository
> repository.save(this.myCompany);
> [Same Server error]
> java.lang.IllegalArgumentException: Region names may only be alphanumeric and 
> may contain hyphens or underscores: 
> companies:f05405c2-86f2-4aaf-bd0c-6fecd483bf28
> at 
> org.apache.geode.internal.cache.LocalRegion.validateRegionName(LocalRegion.java:7618)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.createVMRegion(GemFireCacheImpl.java:3201)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreateRegion(GemFireCacheImpl.java:3181)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.createRegion(GemFireCacheImpl.java:3169)
> at org.apache.geode.cache.RegionFactory.create(RegionFactory.java:762)
> at 
> org.apache.geode.management.internal.cli.functions.RegionCreateFunction.createRegion(RegionCreateFunction.java:355)
> at 
> org.apache.geode.management.internal.cli.functions.RegionCreateFunction.execute(RegionCreateFunction.java:90)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.executeFunctionLocally(AbstractExecution.java:333)
> at 
> org.apache.geode.internal.cache.execute.A

Re: Review Request 56934: GEODE-2460: update dependency versions

[Mark Bretl]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56934/#review166382
---



Have new versions been checked for any license changes?
Also, I think Anthony has an outstanding pull request for updating the Spring 
Framework version.

- Mark Bretl


On Feb. 22, 2017, 9:09 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56934/
> ---
> 
> (Updated Feb. 22, 2017, 9:09 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-2460
> https://issues.apache.org/jira/browse/GEODE-2460
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> -asm.version = 5.1
> +asm.version = 5.2
> 
> -fastutil.version = 7.0.13
> +fastutil.version = 7.1.0
> 
> -httpclient.version = 4.5.2
> +httpclient.version = 4.5.3
> 
> -netty-all.version = 4.1.7.Final
> -open-json.version = 1.7
> +netty-all.version = 4.1.8.Final
> +open-json.version = 1.8
> 
> -slf4j-api.version = 1.7.22
> +slf4j-api.version = 1.7.23
> 
> -spring-hateoas.version = 0.21.0.RELEASE
> +spring-hateoas.version = 0.23.0.RELEASE
> 
> -spring-ldap-core.version = 2.1.0.RELEASE
> -spring-security.version = 4.1.3.RELEASE
> -spring-tx.version = 4.3.2.RELEASE
> -springframework.version = 4.3.2.RELEASE
> +spring-ldap-core.version = 2.3.1.RELEASE
> +spring-security.version = 4.2.1.RELEASE
> +spring-tx.version = 4.3.6.RELEASE
> +springframework.version = 4.3.6.RELEASE
> 
> -springfox.version=2.6.0
> +springfox.version=2.6.1
> 
> I tried to update selenium.version from 3.0.1 to 3.1.0 but it results in 
> uiTest failures so I backed that out and will file a separate Jira ticket for 
> updating Selenium.
> 
> 
> Diffs
> -
> 
>   gradle/dependency-versions.properties 12a76b4 
> 
> Diff: https://reviews.apache.org/r/56934/diff/
> 
> 
> Testing
> ---
> 
> precheckin passed 100% green
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/24#discussion_r102532340
  
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
   for (int i = 0; i < PATH_MAX && path[i] != 0; i++) {
 path[i] = ::tolower(path[i]);
   }
-  dllNamePtr = strstr(path, "apache-geode.dll");
+  std::string cppName = PRODUCT_LIB_NAME;
+  cppName += ".dll";
+  std::string dotNetName = PRODUCT_DLL_NAME;
+  dotNetName += ".dll";
+  dllNamePtr = strstr(path, cppName.c_str());
--- End diff --

Nit: `strstr` seems old-school.  If you turn `path` into a `std::string` 
then you can use `std::basic_string::find` and do something like.

```cpp
if (pathAsString.find(cppName) == std::string::npos)
{
// ...
}
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2508) Generize lib naming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878899#comment-15878899
 ] 

ASF GitHub Bot commented on GEODE-2508:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/24#discussion_r102532340
  
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
   for (int i = 0; i < PATH_MAX && path[i] != 0; i++) {
 path[i] = ::tolower(path[i]);
   }
-  dllNamePtr = strstr(path, "apache-geode.dll");
+  std::string cppName = PRODUCT_LIB_NAME;
+  cppName += ".dll";
+  std::string dotNetName = PRODUCT_DLL_NAME;
+  dotNetName += ".dll";
+  dllNamePtr = strstr(path, cppName.c_str());
--- End diff --

Nit: `strstr` seems old-school.  If you turn `path` into a `std::string` 
then you can use `std::basic_string::find` and do something like.

```cpp
if (pathAsString.find(cppName) == std::string::npos)
{
// ...
}
```


> Generize lib naming
> ---
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Ernest Burghardt
>
> Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2521) geode native docs: Document installation from source

[Dave Barnes (JIRA)]

Dave Barnes created GEODE-2521:
--

 Summary: geode native docs: Document installation from source
 Key: GEODE-2521
 URL: https://issues.apache.org/jira/browse/GEODE-2521
 Project: Geode
  Issue Type: Improvement
  Components: docs
Reporter: Dave Barnes


Update installation instructions to include building from source. Binary 
distributions will also (presumably) be available on the website's Releases 
page.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2521) geode native docs: Document installation from source

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-2521:
---
Description: Update installation instructions to include building from 
source. Binary distributions will also (presumably) be available on the 
website's Releases page. (See the installation section of the Geode user manual 
for a model to follow.)  (was: Update installation instructions to include 
building from source. Binary distributions will also (presumably) be available 
on the website's Releases page.)

> geode native docs: Document installation from source
> 
>
> Key: GEODE-2521
> URL: https://issues.apache.org/jira/browse/GEODE-2521
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> Update installation instructions to include building from source. Binary 
> distributions will also (presumably) be available on the website's Releases 
> page. (See the installation section of the Geode user manual for a model to 
> follow.)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...

[echobravopapa]

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/24#discussion_r102538789
  
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
 $
 )
 add_dependencies(client-libraries apache-geode)
-set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}")
+set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}" OUTPUT_NAME ${PRODUCT_LIB_NAME} )
--- End diff --

will adjust that.  cmake did not like duplicate calls to 
set_target_properites


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2508) Generize lib naming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878943#comment-15878943
 ] 

ASF GitHub Bot commented on GEODE-2508:
---

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/24#discussion_r102538789
  
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
 $
 )
 add_dependencies(client-libraries apache-geode)
-set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}")
+set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}" OUTPUT_NAME ${PRODUCT_LIB_NAME} )
--- End diff --

will adjust that.  cmake did not like duplicate calls to 
set_target_properites


> Generize lib naming
> ---
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Ernest Burghardt
>
> Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2508) Generize lib naming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878945#comment-15878945
 ] 

ASF GitHub Bot commented on GEODE-2508:
---

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/24#discussion_r102539038
  
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
   for (int i = 0; i < PATH_MAX && path[i] != 0; i++) {
 path[i] = ::tolower(path[i]);
   }
-  dllNamePtr = strstr(path, "apache-geode.dll");
+  std::string cppName = PRODUCT_LIB_NAME;
+  cppName += ".dll";
+  std::string dotNetName = PRODUCT_DLL_NAME;
+  dotNetName += ".dll";
+  dllNamePtr = strstr(path, cppName.c_str());
--- End diff --

fair nit 👍 will change it


> Generize lib naming
> ---
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Ernest Burghardt
>
> Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...

[echobravopapa]

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/24#discussion_r102539038
  
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
   for (int i = 0; i < PATH_MAX && path[i] != 0; i++) {
 path[i] = ::tolower(path[i]);
   }
-  dllNamePtr = strstr(path, "apache-geode.dll");
+  std::string cppName = PRODUCT_LIB_NAME;
+  cppName += ".dll";
+  std::string dotNetName = PRODUCT_DLL_NAME;
+  dotNetName += ".dll";
+  dllNamePtr = strstr(path, cppName.c_str());
--- End diff --

fair nit 👍 will change it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #23: GEODE-2478: Replace gf with geode.

[PivotalSarge]

Github user PivotalSarge commented on the issue:

https://github.com/apache/geode-native/pull/23
  
Good idea. I think you're right about redundancies. I'll look into that.

Sarge

> On 22 Feb, 2017, at 10:48, Jacob Barrett  wrote:
> 
> @pivotal-jbarrett approved this pull request.
> 
> I would suggest opening a ticket with any cleanup ideas you may have seen 
when going through all these headers. Seems like geode_defs and geode_base and 
and whatever generically named includes we have might be fairly redundant and 
ripe for cleanup or reorganization.
> 
> Otherwise this looks good.
> 
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub 
, or 
mute the thread 
.
> 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2478) Replace gf with geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878969#comment-15878969
 ] 

ASF GitHub Bot commented on GEODE-2478:
---

Github user PivotalSarge commented on the issue:

https://github.com/apache/geode-native/pull/23
  
Good idea. I think you're right about redundancies. I'll look into that.

Sarge

> On 22 Feb, 2017, at 10:48, Jacob Barrett  wrote:
> 
> @pivotal-jbarrett approved this pull request.
> 
> I would suggest opening a ticket with any cleanup ideas you may have seen 
when going through all these headers. Seems like geode_defs and geode_base and 
and whatever generically named includes we have might be fairly redundant and 
ripe for cleanup or reorganization.
> 
> Otherwise this looks good.
> 
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub 
, or 
mute the thread 
.
> 




> Replace gf with geode
> -
>
> Key: GEODE-2478
> URL: https://issues.apache.org/jira/browse/GEODE-2478
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>
> The substring "gf" still occurs in some places in the native client codebase. 
> It ought to be replaced with "geode" or "geode-native", whichever makes more 
> sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2522) Refactor Lucene D Unit tests

[Jason Huynh (JIRA)]

Jason Huynh created GEODE-2522:
--

 Summary: Refactor Lucene D Unit tests
 Key: GEODE-2522
 URL: https://issues.apache.org/jira/browse/GEODE-2522
 Project: Geode
  Issue Type: Improvement
  Components: lucene
Reporter: Jason Huynh


Currently our dunit tests for lucene are organized as a tree heirarchy based on 
region types.  This makes it difficult to add a tests for a specific type of 
region type as other test files can possibly extend the file we add the test to.

Instead we can use parameterized tests and flatten the heirarchy.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #23: GEODE-2478: Replace gf with geode.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2478) Replace gf with geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878977#comment-15878977
 ] 

ASF GitHub Bot commented on GEODE-2478:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/23


> Replace gf with geode
> -
>
> Key: GEODE-2478
> URL: https://issues.apache.org/jira/browse/GEODE-2478
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>
> The substring "gf" still occurs in some places in the native client codebase. 
> It ought to be replaced with "geode" or "geode-native", whichever makes more 
> sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2478) Replace gf with geode

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878975#comment-15878975
 ] 

ASF subversion and git services commented on GEODE-2478:


Commit 46f71fde815fdfbfc6b7c16534eb91e275cbbcc0 in geode-native's branch 
refs/heads/develop from [~PivotalSarge]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=46f71fd ]

GEODE-2478: Replace gf with geode.

- Rename directories and files with gf into their name to
  instead use geode and update all references thereto.
- Ensure formatting style guide compliance.
- Elide duplicate GEODE_ from include guards.

This closes #23.


> Replace gf with geode
> -
>
> Key: GEODE-2478
> URL: https://issues.apache.org/jira/browse/GEODE-2478
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>
> The substring "gf" still occurs in some places in the native client codebase. 
> It ought to be replaced with "geode" or "geode-native", whichever makes more 
> sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #22: GEODE-2516: Fix quickstart install to retain ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2516) Script to Run Quickstarts not exectable

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878979#comment-15878979
 ] 

ASF subversion and git services commented on GEODE-2516:


Commit 59cfa9f64d70c5285fdc854a56abcd03830d8ef7 in geode-native's branch 
refs/heads/develop from [~mmartell]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=59cfa9f ]

GEODE-2516: Fix quickstart install to retain permissions.

- By default cmake install unsets the execute bit. To retain it add 
USE_SOURCE_PERMISSIONS flag.

This closes #22.


> Script to Run Quickstarts not exectable
> ---
>
> Key: GEODE-2516
> URL: https://issues.apache.org/jira/browse/GEODE-2516
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Martell
>
> The runcpp.sh script for running the native client quickstarts is not 
> executable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2516) Script to Run Quickstarts not exectable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878980#comment-15878980
 ] 

ASF GitHub Bot commented on GEODE-2516:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/22


> Script to Run Quickstarts not exectable
> ---
>
> Key: GEODE-2516
> URL: https://issues.apache.org/jira/browse/GEODE-2516
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Martell
>
> The runcpp.sh script for running the native client quickstarts is not 
> executable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #17: GEODE-2440: Switch hashcode() return type.

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/17
  
Please close this pull request and resubmit when you have cleaned up all 
the places that use hashcode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2440) Fix CacheableKey::hashcode to int32_t to match Server.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878986#comment-15878986
 ] 

ASF GitHub Bot commented on GEODE-2440:
---

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/17
  
Please close this pull request and resubmit when you have cleaned up all 
the places that use hashcode.


> Fix CacheableKey::hashcode to int32_t to match Server.
> --
>
> Key: GEODE-2440
> URL: https://issues.apache.org/jira/browse/GEODE-2440
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56933: Attempt to refactor the Lucene DUnit tests

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56933/#review166392
---


Ship it!




Ship It!

- nabarun nag


On Feb. 22, 2017, 5:09 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56933/
> ---
> 
> (Updated Feb. 22, 2017, 5:09 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, 
> Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> LuceneDUnitTest and LuceneQueriesAccessorBase are base type classes similar 
> to the old LuceneDUnitTest and LuceneQueriesBase. 
> 
> Made the tests parameterized with a RegionTestableType enum.  This enum 
> "knows" how to create a region provided a cache and a name.
> 
> Renamed the tests by functionality
> 
> Some of the refactoring is a bit clunky as some of our tests were expecting a 
> different behavior with initDataStore based on the region type.  If it were 
> not for that, 2 more classes could have been removed.
> 
> If this is ok, then we'd probably want to change the Integration tests to 
> look similar.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
> 9318b0e 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java
>  6a02a25 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationOnFixedPRDUnitTest.java
>  7de12e3 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesAccessorBase.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesBase.java
>  1b1167c 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesClientDUnitTest.java
>  36ede16 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java
>  9c2f6ed 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerFixedPRDUnitTest.java
>  2622063 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRDUnitTest.java
>  f65777f 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java
>  86ce713 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRPersistentDUnitTest.java
>  4e809ce 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
>  1b4303a 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceWithRedundancyDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java
>  5a6f774 
> 
> Diff: https://reviews.apache.org/r/56933/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 56933: Attempt to refactor the Lucene DUnit tests

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56933/#review166391
---




geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
(line 70)


If ACCESSOR_PARTITION and PARTITION_PROXY have the same effect we can 
remove one of them as they both zero local max memory.


- nabarun nag


On Feb. 22, 2017, 5:09 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56933/
> ---
> 
> (Updated Feb. 22, 2017, 5:09 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, 
> Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> LuceneDUnitTest and LuceneQueriesAccessorBase are base type classes similar 
> to the old LuceneDUnitTest and LuceneQueriesBase. 
> 
> Made the tests parameterized with a RegionTestableType enum.  This enum 
> "knows" how to create a region provided a cache and a name.
> 
> Renamed the tests by functionality
> 
> Some of the refactoring is a bit clunky as some of our tests were expecting a 
> different behavior with initDataStore based on the region type.  If it were 
> not for that, 2 more classes could have been removed.
> 
> If this is ok, then we'd probably want to change the Integration tests to 
> look similar.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
> 9318b0e 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java
>  6a02a25 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationOnFixedPRDUnitTest.java
>  7de12e3 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesAccessorBase.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesBase.java
>  1b1167c 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesClientDUnitTest.java
>  36ede16 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java
>  9c2f6ed 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerFixedPRDUnitTest.java
>  2622063 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRDUnitTest.java
>  f65777f 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java
>  86ce713 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRPersistentDUnitTest.java
>  4e809ce 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
>  1b4303a 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceWithRedundancyDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java
>  5a6f774 
> 
> Diff: https://reviews.apache.org/r/56933/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

off heap

[Dor Ben Dov]

Hi,

Can one tell me how does the off heap flags solution is being done. I mean what 
solution is being used for it ? 



Regards,
Dor
This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at http://www.amdocs.com/email_disclaimer.asp

Re: off heap

[Anthony Baker]

Hi Dor,

Here’s a few documentation links on off-heap usage:

https://geode.apache.org/docs/guide/managing/heap_use/off_heap_management.html
https://www.slideshare.net/PivotalOpenSourceHub/apache-geode-offheap-storage

Does that help?

Thanks,
Anthony


> On Feb 22, 2017, at 11:17 AM, Dor Ben Dov  wrote:
> 
> Hi,
> 
> Can one tell me how does the off heap flags solution is being done. I mean 
> what solution is being used for it ? 
> 
> 
> 
> Regards,
> Dor
> This message and the information contained herein is proprietary and 
> confidential and subject to the Amdocs policy statement,
> 
> you may review at http://www.amdocs.com/email_disclaimer.asp

Re: [jira] [Created] (GEODE-2435) Redis adapter MULTI behavior is different from Redis

[Swapnil Bawaskar]

Indeed, all you need to do is set -Dgemfire.ALLOW_PERSISTENT_TRANSACTIONS
to true

On Tue, Feb 21, 2017 at 5:22 PM Michael Stolz  wrote:

> This looks like the persistence with transactions issue that Gemfire has.
> There is a system property to allow it to work
>
> --
> Mike Stolz
> Principal Engineer - Gemfire Product Manager
> Mobile: 631-835-4771 <(631)%20835-4771>
>
> On Feb 6, 2017 4:41 PM, "Galen O'Sullivan (JIRA)"  wrote:
>
> > Galen O'Sullivan created GEODE-2435:
> > ---
> >
> >  Summary: Redis adapter MULTI behavior is different from
> Redis
> >  Key: GEODE-2435
> >  URL: https://issues.apache.org/jira/browse/GEODE-2435
> >  Project: Geode
> >   Issue Type: Bug
> > Reporter: Galen O'Sullivan
> >
> >
> > {{WATCH}} isn't implemented properly, but this is about returning an
> error
> > instead of nil when we have a {{MULTI}} fail:
> > {code}
> > $ redis-cli -p 11212
> > 127.0.0.1:11212> set a b
> > OK
> > 127.0.0.1:11212> watch a
> > (error) ERR Keys cannot be watched or unwatched because GemFire watches
> > all keys by default for transactions
> > 127.0.0.1:11212> lpush la boo
> > (integer) 1
> > (2.09s)
> > 127.0.0.1:11212> multi
> > OK
> > 127.0.0.1:11212> lpush la z
> > QUEUED
> > 127.0.0.1:11212> lpush la x
> > QUEUED
> > {code}
> > At this point, we {{lpush la foo}} in a different client, then:
> > {code}
> > 127.0.0.1:11212> exec
> > 1) (error) ERR The server had an internal error please try again
> > 2) (error) ERR The server had an internal error please try again
> > 127.0.0.1:11212>
> > {code}
> >
> > whereas a Redis instance will simply return nil instead of an error.
> >
> > Looking in the logs, I see this:
> > {code}
> > [error 2017/02/06 13:21:39.493 PST server2
> 
> > tid=0x2a] GeodeRedisServer-Unexpected error handler for [id: 0x3ddf9f21,
> /
> > 127.0.0.1:58862 => /127.0.0.1:11212]
> > java.lang.UnsupportedOperationException: Operations on persist-backup
> > regions are not allowed because this thread has an active transaction
> > at org.apache.geode.internal.cache.TXRegionState.(
> > TXRegionState.java:60)
> > at org.apache.geode.internal.cache.TXBucketRegionState.<
> > init>(TXBucketRegionState.java:29)
> > at org.apache.geode.internal.cache.TXState.writeRegion(
> > TXState.java:252)
> > at org.apache.geode.internal.cache.TXState.txWriteRegion(
> > TXState.java:1110)
> > at org.apache.geode.internal.cache.TXState.txReadEntry(
> > TXState.java:1365)
> > at org.apache.geode.internal.cache.TXState.txReadEntry(
> > TXState.java:1344)
> > at org.apache.geode.internal.cache.TXState.
> > getDeserializedValue(TXState.java:1414)
> > at org.apache.geode.internal.cache.TXStateProxyImpl.
> > getDeserializedValue(TXStateProxyImpl.java:352)
> > at org.apache.geode.internal.cache.LocalRegion.get(
> > LocalRegion.java:1394)
> > at org.apache.geode.internal.cache.PartitionedRegionDataStore.
> > getLocally(PartitionedRegionDataStore.java:2047)
> > at org.apache.geode.internal.cache.PartitionedRegion.
> > getFromBucket(PartitionedRegion.java:4022)
> > at org.apache.geode.internal.cache.PartitionedRegion.
> > findObjectInSystem(PartitionedRegion.java:3399)
> > at org.apache.geode.internal.cache.TXState.findObject(
> > TXState.java:1540)
> > at org.apache.geode.internal.cache.TXStateProxyImpl.
> > findObject(TXStateProxyImpl.java:614)
> > at org.apache.geode.internal.cache.PartitionedRegion.get(
> > PartitionedRegion.java:3160)
> > at org.apache.geode.internal.cache.LocalRegion.get(
> > LocalRegion.java:1330)
> > at org.apache.geode.internal.cache.AbstractRegion.get(
> > AbstractRegion.java:282)
> > at org.apache.geode.redis.internal.executor.list.
> > ListExecutor.pushElements(ListExecutor.java:70)
> > at org.apache.geode.redis.internal.executor.list.
> > PushExecutor.executeCommand(PushExecutor.java:47)
> > at org.apache.geode.redis.internal.ExecutionHandlerContext.
> > executeWithTransaction(ExecutionHandlerContext.java:244)
> > at org.apache.geode.redis.internal.ExecutionHandlerContext.
> > executeCommand(ExecutionHandlerContext.java:191)
> > at org.apache.geode.redis.internal.ExecutionHandlerContext.
> > channelRead(ExecutionHandlerContext.java:137)
> > at io.netty.channel.DefaultChannelHandlerContext.
> > invokeChannelRead(DefaultChannelHandlerContext.java:368)
> > at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(
> > DefaultChannelHandlerContext.java:353)
> > at io.netty.handler.codec.ByteToMessageDecoder.channelRead(
> > ByteToMessageDecoder.java:173)
> > at io.netty.channel.DefaultChannelHandlerContext.
> > invokeChannelRead(DefaultChannelHandlerContext.java:368)
> > at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(
> > DefaultChannelHandl

Re: Review Request 56934: GEODE-2460: update dependency versions

[Anthony Baker]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56934/#review166406
---



I'll close my PR in favor of these changes.  However, there are some NOTICE 
file updates needed (e.g. see https://github.com/apache/geode/pull/403/files).

- Anthony Baker


On Feb. 22, 2017, 5:09 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56934/
> ---
> 
> (Updated Feb. 22, 2017, 5:09 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-2460
> https://issues.apache.org/jira/browse/GEODE-2460
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> -asm.version = 5.1
> +asm.version = 5.2
> 
> -fastutil.version = 7.0.13
> +fastutil.version = 7.1.0
> 
> -httpclient.version = 4.5.2
> +httpclient.version = 4.5.3
> 
> -netty-all.version = 4.1.7.Final
> -open-json.version = 1.7
> +netty-all.version = 4.1.8.Final
> +open-json.version = 1.8
> 
> -slf4j-api.version = 1.7.22
> +slf4j-api.version = 1.7.23
> 
> -spring-hateoas.version = 0.21.0.RELEASE
> +spring-hateoas.version = 0.23.0.RELEASE
> 
> -spring-ldap-core.version = 2.1.0.RELEASE
> -spring-security.version = 4.1.3.RELEASE
> -spring-tx.version = 4.3.2.RELEASE
> -springframework.version = 4.3.2.RELEASE
> +spring-ldap-core.version = 2.3.1.RELEASE
> +spring-security.version = 4.2.1.RELEASE
> +spring-tx.version = 4.3.6.RELEASE
> +springframework.version = 4.3.6.RELEASE
> 
> -springfox.version=2.6.0
> +springfox.version=2.6.1
> 
> I tried to update selenium.version from 3.0.1 to 3.1.0 but it results in 
> uiTest failures so I backed that out and will file a separate Jira ticket for 
> updating Selenium.
> 
> 
> Diffs
> -
> 
>   gradle/dependency-versions.properties 12a76b4 
> 
> Diff: https://reviews.apache.org/r/56934/diff/
> 
> 
> Testing
> ---
> 
> precheckin passed 100% green
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Assigned] (GEODE-2522) Refactor Lucene D Unit tests

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh reassigned GEODE-2522:
--

Assignee: Jason Huynh

> Refactor Lucene D Unit tests
> 
>
> Key: GEODE-2522
> URL: https://issues.apache.org/jira/browse/GEODE-2522
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> Currently our dunit tests for lucene are organized as a tree heirarchy based 
> on region types.  This makes it difficult to add a tests for a specific type 
> of region type as other test files can possibly extend the file we add the 
> test to.
> Instead we can use parameterized tests and flatten the heirarchy.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2522) Refactor Lucene D Unit tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879137#comment-15879137
 ] 

ASF subversion and git services commented on GEODE-2522:


Commit a63b8302a07475c1726c891152daa9f8947091a6 in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a63b830 ]

GEODE-2522: Flattened heirarchy of Lucene DUnit tests


> Refactor Lucene D Unit tests
> 
>
> Key: GEODE-2522
> URL: https://issues.apache.org/jira/browse/GEODE-2522
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Jason Huynh
>
> Currently our dunit tests for lucene are organized as a tree heirarchy based 
> on region types.  This makes it difficult to add a tests for a specific type 
> of region type as other test files can possibly extend the file we add the 
> test to.
> Instead we can use parameterized tests and flatten the heirarchy.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2520) Add a lucene query test where a bucket is moved while a query is executing

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879136#comment-15879136
 ] 

ASF subversion and git services commented on GEODE-2520:


Commit 0d2397b203060f02b95ece30bf4c7130685b71cd in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0d2397b ]

GEODE-2520: Add a lucene query test where a bucket is moved while a query is 
executing

*  Added LuceneIndexServiceSpy


> Add a lucene query test where a bucket is moved while a query is executing
> --
>
> Key: GEODE-2520
> URL: https://issues.apache.org/jira/browse/GEODE-2520
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> The query should handle this scenario and return the correct results.
> As currently implemented, it should end up retrying the query on the new 
> primary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2523) Collapse RegionTestableTypes combinations into a single enum types

[Jason Huynh (JIRA)]

Jason Huynh created GEODE-2523:
--

 Summary: Collapse RegionTestableTypes combinations into a single 
enum types
 Key: GEODE-2523
 URL: https://issues.apache.org/jira/browse/GEODE-2523
 Project: Geode
  Issue Type: Sub-task
  Components: lucene
Reporter: Jason Huynh


Currently, we have pairs of RegionTestableTypes that are used in the 
LuceneDUnit tests.  These pairs are used to determine the datastore and 
accessor region types.  However the pairings are generally 1 to 1.  So we 
should be able to collapse the types into a single enum and remove the 
parameterized methods.  Instead we should then be able to add the enum name 
into the parameters themselves.

So instead of having the following for a test case
 @Parameters(method = "getListOfClientServerTypes")

We could then have
  @Parameters({"PARTITION", "ETC..."})

we can probably use PARTITION and know that the corresponding client type is 
PARTITION_PROXY.  That or we can change the enum to be explicit about the 
pairing, such as PARTITION_WITH_PARTITION_PROXY.





--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2524) Refactor LuceneIntegration Tests

[Jason Huynh (JIRA)]

Jason Huynh created GEODE-2524:
--

 Summary: Refactor LuceneIntegration Tests
 Key: GEODE-2524
 URL: https://issues.apache.org/jira/browse/GEODE-2524
 Project: Geode
  Issue Type: Improvement
  Components: lucene
Reporter: Jason Huynh


After refactoring the dunit tests, we should probably have the same structure 
for the integration tests.  This means changing them to use parameters and 
removing as many tests inheritance as possible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2524) Refactor LuceneIntegration Tests

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh updated GEODE-2524:
---
Description: 
After refactoring the dunit tests, we should probably have the same structure 
for the integration tests.  This means changing them to use parameters and 
removing as many tests inheritance as possible.

Relates to GEODE-2522

  was:After refactoring the dunit tests, we should probably have the same 
structure for the integration tests.  This means changing them to use 
parameters and removing as many tests inheritance as possible.


> Refactor LuceneIntegration Tests
> 
>
> Key: GEODE-2524
> URL: https://issues.apache.org/jira/browse/GEODE-2524
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Jason Huynh
>
> After refactoring the dunit tests, we should probably have the same structure 
> for the integration tests.  This means changing them to use parameters and 
> removing as many tests inheritance as possible.
> Relates to GEODE-2522



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2357) Update cli quickstarts

[Ernest Burghardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt resolved GEODE-2357.
-
Resolution: Fixed

> Update cli quickstarts
> --
>
> Key: GEODE-2357
> URL: https://issues.apache.org/jira/browse/GEODE-2357
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Michael Martell
>
> Transform Gemfire => Geode as appropriate



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2346) Update GemfireStatisticsFactory

[Ernest Burghardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt resolved GEODE-2346.
-
Resolution: Fixed

> Update  GemfireStatisticsFactory
> 
>
> Key: GEODE-2346
> URL: https://issues.apache.org/jira/browse/GEODE-2346
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Ernest Burghardt
>
> Gem fire => Geode transformation
> the following files are called Gemfire* let's make them Geode*
> src//cppcache/src/statistics/GemfireStatisticsFactory.cpp
> src//cppcache/src/statistics/GemfireStatisticsFactory.hpp
> Also, update inclusions usage and named components as appropriate.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2339) Update gfcpp src

[Ernest Burghardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt resolved GEODE-2339.
-
Resolution: Fixed

> Update gfcpp src
> 
>
> Key: GEODE-2339
> URL: https://issues.apache.org/jira/browse/GEODE-2339
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> Parent task



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2351) Update cpp quickstarts

[Ernest Burghardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt resolved GEODE-2351.
-
Resolution: Fixed

> Update cpp quickstarts
> --
>
> Key: GEODE-2351
> URL: https://issues.apache.org/jira/browse/GEODE-2351
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Ernest Burghardt
>
> Transform Gemfire => Geode as appropriate



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2514) Need more tests for statistics archive rolling and removal

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879200#comment-15879200
 ] 

ASF subversion and git services commented on GEODE-2514:


Commit 76fa7cc7300359afa83c5df30d3af4043b82da27 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=76fa7cc ]

GEODE-2514: add new tests for statistics archive rolling and removal

* add MainWithChildrenRollingFileHandlerIntegrationTest
* add StatArchiveHandlerIntegrationTest
* expand DiskSpaceLimitIntegrationTest


> Need more tests for statistics archive rolling and removal
> --
>
> Key: GEODE-2514
> URL: https://issues.apache.org/jira/browse/GEODE-2514
> Project: Geode
>  Issue Type: Wish
>  Components: statistics
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> We need more integration tests for StatArchiveHandler and 
> MainWithChildrenRollingFileHandler with file system behavior for rolling and 
> removal.
> Rolling is controlled by archive-file-size-limit. Removal is controlled by 
> archive-disk-space-limit.
> Tests should involve the mainId and childId (-01-01) and how they roll. Tests 
> should also involve the marker file used by 
> MainWithChildrenRollingFileHandler.
> Some of the methods that we would like to test in isolation will need to be 
> changed from private to protected (or package private).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2512) Geode Native docs: book fails to build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879204#comment-15879204
 ] 

ASF GitHub Bot commented on GEODE-2512:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/20


> Geode Native docs: book fails to build
> --
>
> Key: GEODE-2512
> URL: https://issues.apache.org/jira/browse/GEODE-2512
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The geode native book fails to build. Need to update and correct the config 
> files in ../geode-native/docs/geode-native-book, and (once book generation is 
> restored) the README.md file needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)