----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56933/ -----------------------------------------------------------
Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, Dan Smith, and xiaojian zhou. Repository: geode Description ------- LuceneDUnitTest and LuceneQueriesAccessorBase are base type classes similar to the old LuceneDUnitTest and LuceneQueriesBase. Made the tests parameterized with a RegionTestableType enum. This enum "knows" how to create a region provided a cache and a name. Renamed the tests by functionality Some of the refactoring is a bit clunky as some of our tests were expecting a different behavior with initDataStore based on the region type. If it were not for that, 2 more classes could have been removed. If this is ok, then we'd probably want to change the Integration tests to look similar. Diffs ----- geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 9318b0e geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java 6a02a25 geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationOnFixedPRDUnitTest.java 7de12e3 geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesAccessorBase.java PRE-CREATION geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesBase.java 1b1167c geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesClientDUnitTest.java 36ede16 geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesDUnitTest.java PRE-CREATION geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java 9c2f6ed geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerFixedPRDUnitTest.java 2622063 geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRDUnitTest.java f65777f geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java 86ce713 geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRPersistentDUnitTest.java 4e809ce geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java 1b4303a geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceDUnitTest.java PRE-CREATION geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceWithRedundancyDUnitTest.java PRE-CREATION geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java 5a6f774 Diff: https://reviews.apache.org/r/56933/diff/ Testing ------- Thanks, Jason Huynh
