[
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878899#comment-15878899
]
ASF GitHub Bot commented on GEODE-2508:
---------------------------------------
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102532340
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
for (int i = 0; i < PATH_MAX && path[i] != 0; i++) {
path[i] = ::tolower(path[i]);
}
- dllNamePtr = strstr(path, "apache-geode.dll");
+ std::string cppName = PRODUCT_LIB_NAME;
+ cppName += ".dll";
+ std::string dotNetName = PRODUCT_DLL_NAME;
+ dotNetName += ".dll";
+ dllNamePtr = strstr(path, cppName.c_str());
--- End diff --
Nit: `strstr` seems old-school. If you turn `path` into a `std::string`
then you can use `std::basic_string::find` and do something like.
```cpp
if (pathAsString.find(cppName) == std::string::npos)
{
// ...
}
```
> Generize lib naming
> -------------------
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
>
> Make naming configurable
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
