[ 
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878943#comment-15878943
 ] 

ASF GitHub Bot commented on GEODE-2508:
---------------------------------------

Github user echobravopapa commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/24#discussion_r102538789
  
    --- Diff: src/cppcache/src/CMakeLists.txt ---
    @@ -125,7 +125,7 @@ target_include_directories(apache-geode
         $<TARGET_PROPERTY:_apache-geode,INTERFACE_INCLUDE_DIRECTORIES>
     )
     add_dependencies(client-libraries apache-geode)
    -set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}")
    +set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}" OUTPUT_NAME ${PRODUCT_LIB_NAME} )
    --- End diff --
    
    will adjust that.  cmake did not like duplicate calls to 
set_target_properites


> Generize lib naming
> -------------------
>
>                 Key: GEODE-2508
>                 URL: https://issues.apache.org/jira/browse/GEODE-2508
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Ernest Burghardt
>
> Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to