[PATCH] D147846: [clangd] Hover: resolve forwarding parameters for CalleeArgInfo

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Makes sense, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147846/new/ https://reviews.llvm.org/D147846 ___

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

nridge added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:986 + const FunctionDecl *FD = nullptr; + llvm::SmallVector Args; + tom-anders wrote: > Unfortunately, while CallExpr and CXXConstructExpr basically have the same > API for getting Ar

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1220 +/// \endcode +bool AfterCSharpProperty; }; HazardyKnusperkeks wrote: > Please sort. :) Are we sure we want THIS to be alphabetic, as this changes the initialize

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 514118. AMS21 added a comment. Remove std::ends from the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files: clang-tools-extra/clang-tidy/performance/AvoidEn

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 added a comment. I've also notices that we don't handle this case std::endl(std::cout); Although a rather unusual thing to use, its still valid and has the same problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein added a comment. Ping (: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] 82fdd5b - [clang][NFC] Make parameters to NoteOverloadCandidate const

Author: Timm Bäder Date: 2023-04-17T09:27:51+02:00 New Revision: 82fdd5b5123ee8528267a5bed1c443a30f3f93d7 URL: https://github.com/llvm/llvm-project/commit/82fdd5b5123ee8528267a5bed1c443a30f3f93d7 DIFF: https://github.com/llvm/llvm-project/commit/82fdd5b5123ee8528267a5bed1c443a30f3f93d7.diff LO

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4525 -const FormatToken *Next = Right.getNextNonComment(); -if (!Next || Next->is(tok::semi)) return false; how is the semi case handled or is it not needed Rep

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:5007-5010 + (Left.is(tok::semi) && Left.Previous && +Left.Previous->is(Keywords.kw_get) && Right.is(tok::r_brace)) || + (Left.is(tok::semi) && Left.Previous && +Left.Previou

[PATCH] D143870: [clang-format] Remove all include duplicates not only those in the same block

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. I know it might not seem an obvious use case but there really isn't a requirement to not include header files more than once.. imaging if I have #define ARCH "win32" #include "MyDataStructThatContainsPlaformSp

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

MyDeveloperDay added a comment. Herald added a reviewer: rymiel. Cloud you include a test that contains multiple levels of nested scope, I'm assuming we won't add an additonal line at every {} level (or will we?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] 455c9ef - [clang][NFC] Use range-for loop in SemaLookup.cpp

Author: Timm Bäder Date: 2023-04-17T09:49:04+02:00 New Revision: 455c9efb41de101eaf5e3d4d521097428b5c75d3 URL: https://github.com/llvm/llvm-project/commit/455c9efb41de101eaf5e3d4d521097428b5c75d3 DIFF: https://github.com/llvm/llvm-project/commit/455c9efb41de101eaf5e3d4d521097428b5c75d3.diff LO

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

sberg created this revision. sberg added a reviewer: erichkeane. Herald added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. sberg requested review of this revision. Herald added a project: clang. This takes inspiration from the standard `nodiscard` a

[PATCH] D148506: [C++] Don't filter using declaration when we perform qualified look up

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, erichkeane, aaron.ballman, cor3ntin, clang-language-wg. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Close https://github.com/llv

[PATCH] D148506: [C++] Don't filter using declaration when we perform qualified look up

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:1824-1826 +static bool isUsingDeclAtClassScope(NamedDecl *D) { + if (D->getDeclContext()->isFileContext()) +return false; This is the ad-hoc change. Look at the following comment. ===

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

Fznamznon added a comment. @aaron.ballman , are you ok with the change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148206/new/ https://reviews.llvm.org/D148206 ___ cfe-commits mailing list cfe-commits

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:714 // are in a control flow statements as well as several style flags. -if (Line.First->is(tok::kw_case) || +if (Line.First->is(tok::kw_case) || Line.Last->is(TT_GotoLa

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:1220 +/// \endcode +bool AfterCSharpProperty; }; MyDeveloperDay wrote: > HazardyKnusperkeks wrote: > > Please sort. :) > Are we sure we want THIS to be alphabetic

[PATCH] D148410: [Parse] Remove TimeTraceScope for "ParseTemplate"

MaggieYi added a comment. Thanks @MaskRay, the fix is fine for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148410/new/ https://reviews.llvm.org/D148410 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D143870: [clang-format] Remove all include duplicates not only those in the same block

Febbe added a comment. In D143870#4273075 , @MyDeveloperDay wrote: > I know it might not seem an obvious use case but there really isn't a > requirement to not include header files more than once.. imagine if I have > > #define ARCH "win32" > #inclu

[PATCH] D148462: [clang-tidy] Ignore declarations in bugprone-exception-escape

isuckatcs added a comment. > "The warning was emitted at every occurence of the function. It might be > confusing if it's only emitted for the definition." > Why ? Issue is in definition, not declaration. For me it would be confusing, because the forward declaration is naming the same function

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1220 +/// \endcode +bool AfterCSharpProperty; }; HazardyKnusperkeks wrote: > MyDeveloperDay wrote: > > HazardyKnusperkeks wrote: > > > Please sort. :) > > Are we sure

[PATCH] D148462: [clang-tidy] Ignore declarations in bugprone-exception-escape

PiotrZSL added a comment. @isuckatcs "Technically the exception is propagated through the function until a handler is found that catches it." No because indirectly_recursive called from recursion_helper is noexcept, so there will be std::terminate called. "Also we have cross translation unit an

[PATCH] D148462: [clang-tidy] Ignore declarations in bugprone-exception-escape

PiotrZSL added a comment. @isuckatcs "Note that this particular warning is reported for the function and not for something inside the definition." Function declaration is not a function. A function declaration is a statement in programming languages that declares the existence of a function, i

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. Thanks for the review! I'll simplify the masks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/ https://reviews.llvm.org/D143287 ___ cfe-commits mailing list cfe-c

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

BeMg added inline comments. Comment at: clang/test/CodeGen/RISCV/ntlh-intrinsics/riscv32-zihintntl.c:19 +typedef signed short v8ss __attribute__((vector_size(16))); +typedef signed char v16sc __attribute__((vector_size(16))); +v4si v4si1, v4si2; craig.topper wrot

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

jplehr added a comment. I'll get back to this soon, enjoyed vacation. ;) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134 "specifier in SFINAE context?"); -if (!hasReachableDefinition(PartialSpec)) +if (PartialSpec->hasDefinition() && +

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne added a subscriber: arphaman. ldionne added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:431 + // libc++.dylib in the toolchain. + if ((!Args.hasArg(options::OPT_nostdinc, options::OPT_nostdlibinc, +options::OPT_nostdincxx)) &&

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 514160. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/I

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:583 + llvm::sys::path::Style Style = + llvm::sys::path::is_absolute(ObjFileNameForDebug) + ? llvm::sys::path::Style::native zequanwu wrote: > hans wrote: > > Won't the co

[PATCH] D148435: [clang-repl] Do not assert if we have weak references left.

junaire accepted this revision. junaire added a comment. This revision is now accepted and ready to land. This patch fixes issues that have not been found in the past. This unblocks D141215 and D146809 . Since it's only relevan

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148206/new/ https://reviews.llvm.org/D148206 ___ cfe-commits mailing list cfe-comm

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

Fznamznon marked an inline comment as not done. Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:808 unsigned NumElems = numStructUnionElements(ILE->getType()); - if (RDecl->hasFlexibleArrayMember()) + if (!RDecl->isUnion() && RDecl->hasFl

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5184dc2d7cce: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value (authored by ManuelJBrito). Changed prior to commit:

[clang] 5184dc2 - [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

Author: ManuelJBrito Date: 2023-04-17T12:58:36+01:00 New Revision: 5184dc2d7cce5971f4386c6f99d04f87233dd313 URL: https://github.com/llvm/llvm-project/commit/5184dc2d7cce5971f4386c6f99d04f87233dd313 DIFF: https://github.com/llvm/llvm-project/commit/5184dc2d7cce5971f4386c6f99d04f87233dd313.diff

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:808 unsigned NumElems = numStructUnionElements(ILE->getType()); - if (RDecl->hasFlexibleArrayMember()) + if (!RDecl->isUnion() && RDecl->hasFlexibleArrayMember()) ++NumElems; --

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175

[PATCH] D148515: [Modules] Do not rewrite existing decls when deserializing class fields

ilya-biryukov created this revision. ilya-biryukov added a reviewer: ChuanqiXu. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Classes can have implicit members that were added before fields were

[PATCH] D143870: [clang-format] Remove all include duplicates not only those in the same block

MyDeveloperDay added a comment. > Regarding the comment that I must not change existing tests: I think this > rule is too strict, because those tests are mostly regression tests. > But a regression tests does not test for correctness. So if a test had > already a wrong assumption, it must be ch

[PATCH] D148426: [clang][Interp] IntegralComplexToBoolean casts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor cleanup. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1165 +return visit(LV); + return false; tbaeder wr

[PATCH] D148515: [Modules] Do not rewrite existing decls when deserializing class fields

ilya-biryukov added a comment. I plan to land this together with a reland of bc95f27337c7ed77c28e713c855272848f01802a and finally close GH61065 . I have checked this works on

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:808 unsigned NumElems = numStructUnionElements(ILE->getType()); - if (RDecl->hasFlexibleArrayMember()) + if (!RDecl->isUnion() && RDecl->hasFlexibleArrayMember()) ++NumElems; --

[PATCH] D148419: [clang][AST] Constexpr evaluator should treat [[gnu::weak]] member pointer comparisons as evaluation failure

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though the changes need a release note. Do you still need someone to commit on your behalf? (Alternatively, you could consider requesting commit access: https://llvm.org/do

[clang] 9d9046f - [clang] Do not crash after suggesting typo correction to constexpr if condition

Author: Mariya Podchishchaeva Date: 2023-04-17T08:28:49-04:00 New Revision: 9d9046f06d55692c5be51164694a4959d9e212b2 URL: https://github.com/llvm/llvm-project/commit/9d9046f06d55692c5be51164694a4959d9e212b2 DIFF: https://github.com/llvm/llvm-project/commit/9d9046f06d55692c5be51164694a4959d9e212

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d9046f06d55: [clang] Do not crash after suggesting typo correction to constexpr if condition (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D148206?vs=513497&id=514174#toc

[PATCH] D148419: [clang][AST] Constexpr evaluator should treat [[gnu::weak]] member pointer comparisons as evaluation failure

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/crash-lambda-weak-attr.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++2b %s + I don't think we need this to be in C++2b mode explicitly, right? Repository: rG LLVM Github Monorepo C

[PATCH] D148419: [clang][AST] Constexpr evaluator should treat [[gnu::weak]] member pointer comparisons as evaluation failure

hazohelet updated this revision to Diff 514179. hazohelet added a comment. Address comments from @aaron.ballman - Added release note - Do not specify std c++ version in test code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148419/new/ https://reviews.llvm.org/D148419 Files: clang/

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis added a comment. ping for reviews. Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D148419: [clang][AST] Constexpr evaluator should treat [[gnu::weak]] member pointer comparisons as evaluation failure

hazohelet marked an inline comment as done. hazohelet added a comment. In D148419#4273551 , @aaron.ballman wrote: > LGTM, though the changes need a release note. Do you still need someone to > commit on your behalf? (Alternatively, you could consider re

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

mboehme updated this revision to Diff 514182. mboehme added a comment. Changes in reponse to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145581/new/ https://reviews.llvm.org/D145581 Files: clang-tools-extra/clang-tidy/bugprone

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

mboehme updated this revision to Diff 514188. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145581/new/ https://reviews.llvm.org/D145581 Files: clang-tools-extra/clang-tidy/bugprone

[PATCH] D148525: [OpenMP][AMDGPU] Refactor setting uniform work group size attribute

domada created this revision. domada added reviewers: jsjodin, ronlieb, dpalermo, JonChesterfield, agozillon, gregrodgers, skatrak, raghavendhra, RogerV-AMD, saiislam. domada added projects: OpenMP, AMDGPU. Herald added subscribers: sunshaoce, kosarev, guansong, hiraditya, tpr, dstuttard, yaxunl,

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet added a comment. In D146358#4268327 , @tbaeder wrote: > So, if I understand the code correctly, we call `CheckEvaluationResult` with > `SubObjectDecl=nullptr` when we're not checking an actual field but just an > array/record, so we can't run

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

mboehme marked 3 inline comments as done. mboehme added a comment. In D145581#4215602 , @PiotrZSL wrote: > Switching status of review, once you will be ready with changes (or your > decision), just mark it ready for review again. Did I do this correctly

[clang] e98776a - [clang] Add __is_trivially_equality_comparable

Author: Nikolas Klauser Date: 2023-04-17T15:36:21+02:00 New Revision: e98776a180a74c08dcc07cebf26c11deac6e975a URL: https://github.com/llvm/llvm-project/commit/e98776a180a74c08dcc07cebf26c11deac6e975a DIFF: https://github.com/llvm/llvm-project/commit/e98776a180a74c08dcc07cebf26c11deac6e975a.dif

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

This revision was automatically updated to reflect the committed changes. Closed by commit rGe98776a180a7: [clang] Add __is_trivially_equality_comparable (authored by philnik). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://review

[PATCH] D148529: [clang] Replace find_executable with shutil.which in creduce script

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. distutils is deprecated and shutil.which is the suggested replacement for this function. https://peps.python.or

[clang] a4edc2c - Constexpr evaluator should treat [[gnu::weak]] member pointer comparisons as evaluation failure

Author: Takuya Shimizu Date: 2023-04-17T09:50:46-04:00 New Revision: a4edc2c9fa35a763fc5f4c9cf6383096a13a9cf6 URL: https://github.com/llvm/llvm-project/commit/a4edc2c9fa35a763fc5f4c9cf6383096a13a9cf6 DIFF: https://github.com/llvm/llvm-project/commit/a4edc2c9fa35a763fc5f4c9cf6383096a13a9cf6.diff

[PATCH] D148419: [clang][AST] Constexpr evaluator should treat [[gnu::weak]] member pointer comparisons as evaluation failure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4edc2c9fa35: Constexpr evaluator should treat [[gnu::weak]] member pointer comparisons as… (authored by hazohelet, committed by aaron.ballman). Re

[PATCH] D148419: [clang][AST] Constexpr evaluator should treat [[gnu::weak]] member pointer comparisons as evaluation failure

hazohelet marked an inline comment as done. hazohelet added a comment. @aaron.ballman Sorry, this change is breaking the buildbot and because I don't have commit access I would like you to revert it for me. It seems we need to specify the std option in the test code. BUILD FAILED: 41435 expec

[clang] 56f7052 - Speculatively fix a failing bot

Author: Aaron Ballman Date: 2023-04-17T10:10:00-04:00 New Revision: 56f7052d9226838b745970c4156be30ee209ee03 URL: https://github.com/llvm/llvm-project/commit/56f7052d9226838b745970c4156be30ee209ee03 DIFF: https://github.com/llvm/llvm-project/commit/56f7052d9226838b745970c4156be30ee209ee03.diff

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:227 +(TSTy = Ty->getAs())) + Result.addOuterTemplateArguments(const_cast(FTD), + TSTy->template_arguments(), So I'd come up

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav reclaimed this revision. chaitanyav added a comment. re-opening the revision to make further updates as per comments on the github issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 __

[PATCH] D148419: [clang][AST] Constexpr evaluator should treat [[gnu::weak]] member pointer comparisons as evaluation failure

aaron.ballman added a comment. In D148419#4273901 , @hazohelet wrote: > @aaron.ballman > Sorry, this change is breaking the buildbot and because I don't have commit > access I would like you to revert it for me. > It seems we need to specify the std opt

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

aaron.ballman added a comment. Thank you for working on this! The only thing I think is missing is a release note, though I did have a question on a change in the tests. Comment at: clang/test/Sema/parentheses.cpp:34 public: - operator int(); + operator bool(); Stream &o

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

erichkeane added a comment. I don't see a problem with this, but the changes to the pragma tests concern me a bit, so I'd like aaron to scroll through. The Expr.cpp and Sema changes both look right to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

bryanpkc added a comment. `clang/test/Driver/flang/multiple-inputs-mixed.f90` uses a more general FileCheck pattern: ! CHECK-SYNTAX-ONLY-LABEL: "{{[^"]*}}flang-new{{[^"/]*}}" "-fc1" Perhaps these files should use the same regexp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:432 if (sysroot != "") { CmdArgs.push_back("-syslibroot"); CmdArgs.push_back(C.getArgs().MakeArgString(sysroot)); ldionne wrote: > ldionne wrote: > > Where do we se

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 514232. krzysz00 added a comment. Fix new merge conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/test/Co

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:583 + llvm::sys::path::Style Style = + llvm::sys::path::is_absolute(ObjFileNameForDebug) + ? llvm::sys::path::Style::native hans wrote: > zequanwu wrote: > > hans wro

[clang-tools-extra] f099f2f - [clangd] Use all inputs to SystemIncludeExtractor in cache key

Author: Kadir Cetinkaya Date: 2023-04-17T16:57:33+02:00 New Revision: f099f2fefbab0592c828573d816b46a475076f49 URL: https://github.com/llvm/llvm-project/commit/f099f2fefbab0592c828573d816b46a475076f49 DIFF: https://github.com/llvm/llvm-project/commit/f099f2fefbab0592c828573d816b46a475076f49.dif

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

This revision was automatically updated to reflect the committed changes. Closed by commit rGf099f2fefbab: [clangd] Use all inputs to SystemIncludeExtractor in cache key (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146941/new

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM unless anyone else has any concerns. Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33 +//. +// CHECK-NVIDIA: @local_a = internal addrspace(3) global [

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:189-190 preprocessor operators now return 1 also for attributes defined by plugins. +- In C++, the ``__attribute__((warn_unused))`` can now also be used on individual + constructors, -

[PATCH] D148529: [clang] Replace find_executable with shutil.which in creduce script

zequanwu accepted this revision. zequanwu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148529/new/ https://reviews.llvm.org/D148529 __

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added a comment. In D144634#4272857 , @koops wrote: > 1. Adding semantic test clang/test/OpenMP/loop_bind_messages.cpp. > 2. Changes suggested by Alexey. > 3. >Why need to drop bind clause here? The new Directives to which loop > directive is bei

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added a comment. Also, add AST printing tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

sstwcw updated this revision to Diff 514249. sstwcw added a comment. - Remove change in line wrapping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148484/new/ https://reviews.llvm.org/D148484 Files: clang/lib/Format/FormatToken.h clang/lib/Fo

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

sstwcw marked 3 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4525 -const FormatToken *Next = Right.getNextNonComment(); -if (!Next || Next->is(tok::semi)) return false; MyDeveloperDay wrote:

[PATCH] D148529: [clang] Replace find_executable with shutil.which in creduce script

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee3413736251: [clang] Replace find_executable with shutil.which in creduce script (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[clang] ee34137 - [clang] Replace find_executable with shutil.which in creduce script

Author: David Spickett Date: 2023-04-17T15:33:06Z New Revision: ee341373625163846f4ebc68e46aec6fb46c2c09 URL: https://github.com/llvm/llvm-project/commit/ee341373625163846f4ebc68e46aec6fb46c2c09 DIFF: https://github.com/llvm/llvm-project/commit/ee341373625163846f4ebc68e46aec6fb46c2c09.diff LOG

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet updated this revision to Diff 514252. hazohelet added a comment. Remove `gnu::weak` diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146358/new/ https://reviews.llvm.org/D146358 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticASTKinds.td clang/l

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

shafik added subscribers: aaron.ballman, rsmith. shafik added inline comments. Comment at: clang/test/CXX/drs/dr18xx.cpp:139 +namespace dr1890 { // dr1890: no drafting +// FIXME: all the examples are well-formed. So this is still in drafting: https://www.open-

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

sberg added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2996 let Spellings = [GCC<"warn_unused">]; - let Subjects = SubjectList<[Record]>; + let Subjects = SubjectList<[Record, CXXConstructor]>; let Documentation = [Undocumented]; aaron

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta updated this revision to Diff 514262. xgupta added a comment. adjust the return and add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 Files: clang/test/clang-rename/NonExistFile.cpp

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

shafik added inline comments. Comment at: clang/test/CXX/drs/dr16xx.cpp:46 +namespace dr1626 { // dr1626: no open +// FIXME: all of the examples are well-formed +#if __cplusplus >= 201103L Since this is still open, should we be expressing an opinion on whether th

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4272904 , @kbobyrev wrote: > Oh, wait, I'm sorry, I didn't look into it closely :( Yeah, the `Input` file > is not really needed, most of the time the users of `clang-rename` (not sure > there are many with `clangd` be

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

bcain added a comment. Can you depend on `cstdio` in an LLVM toolchain test case like this? `clang` doesn't install `cstdio` -- does it? This is a c or c++ library file, so I think it should be out of scope for a clang test, right? AFAICT no other clang test uses this header file. ===

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:42 +namespace dr2335 { // dr2335: no drafting +// FIXME: all of the examples are well-formed. shafik wrote: > My comment on 1890 applies here as well. > > CC @rsmith @aaron.ballman how sho

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

browneee accepted this revision. browneee added a comment. LGTM `release_shadow_space.c:29: size_t get_rss_kb(): Assertion ```feof(f)' failed.` `custom.cpp:1858: void test_sprintf(): Assertion ```strcmp(buf, "Hello world!") == 0' failed.` Issue appears to be with the program rather than the in

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

sgraenitz added inline comments. Comment at: clang/test/Interpreter/dynamic-library.cpp:6 + +#include + bcain wrote: > This test fails for me like below. > > > ``` > FAIL: Clang :: Interpreter/dynamic-library.cpp (1 of 17751) > TEST 'Cla

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1183-1185 +if (!ReadAnyTokensBeforeDirective) { + CurPPLexer->MIOpt.ResetReadToken(); +} NFC but matches our style guide. One thing to consider: making the call a setter

[clang] 836786a - [NFC][Assignment Tracking] Rename flag variable in Options.td

Author: OCHyams Date: 2023-04-17T17:43:52+01:00 New Revision: 836786ab7f6c5d94458fe4136807bfea6184e270 URL: https://github.com/llvm/llvm-project/commit/836786ab7f6c5d94458fe4136807bfea6184e270 DIFF: https://github.com/llvm/llvm-project/commit/836786ab7f6c5d94458fe4136807bfea6184e270.diff LOG:

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:42 +namespace dr2335 { // dr2335: no drafting +// FIXME: all of the examples are well-formed. Endill wrote: > shafik wrote: > > My comment on 1890 applies here as well. > > > > CC @

[clang] 1f5e737 - [clang][cmake] Add options to pass in vcs repo and revision info

Author: Han Zhu Date: 2023-04-17T09:50:18-07:00 New Revision: 1f5e737fc135bf991889a1364b8f8c5edc3953d2 URL: https://github.com/llvm/llvm-project/commit/1f5e737fc135bf991889a1364b8f8c5edc3953d2 DIFF: https://github.com/llvm/llvm-project/commit/1f5e737fc135bf991889a1364b8f8c5edc3953d2.diff LOG:

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f5e737fc135: [clang][cmake] Add options to pass in vcs repo and revision info (authored by zhuhan0). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

argentite added a comment. We should probably also address the lack of linker issue as well. Should we go for a precompiled dynamic library file? There seems to be some "precedent" of this in other tests. Comment at: clang/test/Interpreter/dynamic-library.cpp:6 + +#include +

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Driver/ToolChains/Clang.cpp:583 + llvm::sys::path::Style Style = + llvm::sys::path::is_absolute(ObjFileNameForDebug) + ? llvm::sys::path

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:227 +(TSTy = Ty->getAs())) + Result.addOuterTemplateArguments(const_cast(FTD), + TSTy->template_arguments(), er

  1   2   >