Author: Timm Bäder Date: 2023-04-17T09:27:51+02:00 New Revision: 82fdd5b5123ee8528267a5bed1c443a30f3f93d7
URL: https://github.com/llvm/llvm-project/commit/82fdd5b5123ee8528267a5bed1c443a30f3f93d7 DIFF: https://github.com/llvm/llvm-project/commit/82fdd5b5123ee8528267a5bed1c443a30f3f93d7.diff LOG: [clang][NFC] Make parameters to NoteOverloadCandidate const Added: Modified: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaOverload.cpp Removed: ################################################################################ diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h index 33d6c40f157fe..c12660081e7c4 100644 --- a/clang/include/clang/Sema/Sema.h +++ b/clang/include/clang/Sema/Sema.h @@ -4076,7 +4076,7 @@ class Sema final { // Emit as a 'note' the specific overload candidate void NoteOverloadCandidate( - NamedDecl *Found, FunctionDecl *Fn, + const NamedDecl *Found, const FunctionDecl *Fn, OverloadCandidateRewriteKind RewriteKind = OverloadCandidateRewriteKind(), QualType DestType = QualType(), bool TakingAddress = false); diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp index ab4300518ecf1..5a8544e3739fe 100644 --- a/clang/lib/Sema/SemaOverload.cpp +++ b/clang/lib/Sema/SemaOverload.cpp @@ -10385,7 +10385,8 @@ enum OverloadCandidateSelect { }; static std::pair<OverloadCandidateKind, OverloadCandidateSelect> -ClassifyOverloadCandidate(Sema &S, NamedDecl *Found, FunctionDecl *Fn, +ClassifyOverloadCandidate(Sema &S, const NamedDecl *Found, + const FunctionDecl *Fn, OverloadCandidateRewriteKind CRK, std::string &Description) { @@ -10409,7 +10410,7 @@ ClassifyOverloadCandidate(Sema &S, NamedDecl *Found, FunctionDecl *Fn, if (CRK & CRK_Reversed) return oc_reversed_binary_operator; - if (CXXConstructorDecl *Ctor = dyn_cast<CXXConstructorDecl>(Fn)) { + if (const auto *Ctor = dyn_cast<CXXConstructorDecl>(Fn)) { if (!Ctor->isImplicit()) { if (isa<ConstructorUsingShadowDecl>(Found)) return oc_inherited_constructor; @@ -10428,7 +10429,7 @@ ClassifyOverloadCandidate(Sema &S, NamedDecl *Found, FunctionDecl *Fn, return oc_implicit_copy_constructor; } - if (CXXMethodDecl *Meth = dyn_cast<CXXMethodDecl>(Fn)) { + if (const auto *Meth = dyn_cast<CXXMethodDecl>(Fn)) { // This actually gets spelled 'candidate function' for now, but // it doesn't hurt to split it out. if (!Meth->isImplicit()) @@ -10450,10 +10451,10 @@ ClassifyOverloadCandidate(Sema &S, NamedDecl *Found, FunctionDecl *Fn, return std::make_pair(Kind, Select); } -void MaybeEmitInheritedConstructorNote(Sema &S, Decl *FoundDecl) { +void MaybeEmitInheritedConstructorNote(Sema &S, const Decl *FoundDecl) { // FIXME: It'd be nice to only emit a note once per using-decl per overload // set. - if (auto *Shadow = dyn_cast<ConstructorUsingShadowDecl>(FoundDecl)) + if (const auto *Shadow = dyn_cast<ConstructorUsingShadowDecl>(FoundDecl)) S.Diag(FoundDecl->getLocation(), diag::note_ovl_candidate_inherited_constructor) << Shadow->getNominatedBaseClass(); @@ -10560,7 +10561,7 @@ bool Sema::checkAddressOfFunctionIsAvailable(const FunctionDecl *Function, // Don't print candidates other than the one that matches the calling // convention of the call operator, since that is guaranteed to exist. -static bool shouldSkipNotingLambdaConversionDecl(FunctionDecl *Fn) { +static bool shouldSkipNotingLambdaConversionDecl(const FunctionDecl *Fn) { const auto *ConvD = dyn_cast<CXXConversionDecl>(Fn); if (!ConvD) @@ -10580,7 +10581,7 @@ static bool shouldSkipNotingLambdaConversionDecl(FunctionDecl *Fn) { } // Notes the location of an overload candidate. -void Sema::NoteOverloadCandidate(NamedDecl *Found, FunctionDecl *Fn, +void Sema::NoteOverloadCandidate(const NamedDecl *Found, const FunctionDecl *Fn, OverloadCandidateRewriteKind RewriteKind, QualType DestType, bool TakingAddress) { if (TakingAddress && !checkAddressOfCandidateIsAvailable(*this, Fn)) _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
