Endill added inline comments.

================
Comment at: clang/test/CXX/drs/dr23xx.cpp:42
 
+namespace dr2335 { // dr2335: no drafting
+// FIXME: all of the examples are well-formed.
----------------
shafik wrote:
> My comment on 1890 applies here as well.
> 
> CC @rsmith @aaron.ballman how should we handle DRs that are still in process? 
> While we may think we know the direction it is going in, it could change.
> 
> So maybe we should avoid expressing an opinion on whether these are 
> well-formed or not?
I asked Aaron even before uploading the patch. His response was:
> I think it's a judgement call -- if the CWG consensus seems like it makes a 
> lot of sense, then I see no reason not to test them but maybe leave a FIXME 
> comment about the issue technically being open still. If the CWG consensus 
> doesn't make sense, that might be time to get on the reflectors and ask 
> questions

Consensus documented in 2335 and drafting notes in P1787 that I quote in the 
summary made sense to me, so I published this patch. I can abandon it if there 
are fundamental issues with the them, rendering my judgement wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148433/new/

https://reviews.llvm.org/D148433

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to