aaron.ballman added inline comments.
================ Comment at: clang/lib/Lex/PPDirectives.cpp:1183-1185 + if (!ReadAnyTokensBeforeDirective) { + CurPPLexer->MIOpt.ResetReadToken(); + } ---------------- NFC but matches our style guide. One thing to consider: making the call a setter instead of a reset would simplify this logic into: `CurPPLexer->SetReadToken(ReadAnyTokensBeforeDirective);` without any branching required. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D147928 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits