Pankraz76 commented on code in PR #2436:
URL: https://github.com/apache/maven/pull/2436#discussion_r2133668422
##########
src/mdo/java/WrapperProperties.java:
##########
@@ -208,16 +182,19 @@ interface WriteOpVoid {
}
private <T> T writeOperation(WriteOp<T> runner) {
- ensureInitialized();
- T ret = runner.perform(orderedProps);
- setter.accept(orderedProps);
+ OrderedProperties props = new OrderedProperties(getter.get());
+ T ret = runner.perform(props);
+ if (!props.equals(getter.get())) {
+ setter.accept(props);
+ }
return ret;
}
private void writeOperationVoid(WriteOpVoid runner) {
- ensureInitialized();
- runner.perform(orderedProps);
- setter.accept(orderedProps);
+ writeOperation(properties -> {
+ runner.perform(properties);
+ return null;
Review Comment:
```suggestion
return null;
```
format seems broken as offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
