gnodet commented on code in PR #2436:
URL: https://github.com/apache/maven/pull/2436#discussion_r2134613017
##########
src/mdo/java/WrapperProperties.java:
##########
@@ -208,16 +182,20 @@ interface WriteOpVoid {
}
private <T> T writeOperation(WriteOp<T> runner) {
- ensureInitialized();
- T ret = runner.perform(orderedProps);
- setter.accept(orderedProps);
+ OrderedProperties props = new OrderedProperties(getter.get());
+ T ret = runner.perform(props);
+ if (!props.equals(getter.get())) {
+ setter.accept(props);
+ }
Review Comment:
I've removed the other duplicated code, so no need for a private method with
a single line and a single usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
