gnodet commented on code in PR #2436:
URL: https://github.com/apache/maven/pull/2436#discussion_r2128841420
##########
src/mdo/java/WrapperProperties.java:
##########
@@ -350,28 +325,32 @@ public synchronized void loadFromXML(InputStream in)
throws IOException, Invalid
@Override
public void storeToXML(OutputStream os, String comment) throws IOException
{
- Properties props = new Properties();
- props.putAll(getter.get());
+ OrderedProperties props = new OrderedProperties(getter.get());
props.storeToXML(os, comment);
}
@Override
public void storeToXML(OutputStream os, String comment, String encoding)
throws IOException {
- Properties props = new Properties();
- props.putAll(getter.get());
+ OrderedProperties props = new OrderedProperties(getter.get());
props.storeToXML(os, comment, encoding);
}
private Object writeReplace() throws java.io.ObjectStreamException {
- Properties props = new Properties();
- props.putAll(getter.get());
+ OrderedProperties props = new OrderedProperties(getter.get());
Review Comment:
The variable is neither returned or thrown, it does not apply here.
##########
src/mdo/java/WrapperProperties.java:
##########
@@ -350,28 +325,32 @@ public synchronized void loadFromXML(InputStream in)
throws IOException, Invalid
@Override
public void storeToXML(OutputStream os, String comment) throws IOException
{
- Properties props = new Properties();
- props.putAll(getter.get());
+ OrderedProperties props = new OrderedProperties(getter.get());
Review Comment:
The variable is neither returned or thrown, it does not apply here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
