gnodet commented on code in PR #2436:
URL: https://github.com/apache/maven/pull/2436#discussion_r2128841812
##########
src/mdo/java/WrapperProperties.java:
##########
@@ -324,22 +302,19 @@ public synchronized void load(InputStream inStream)
throws IOException {
@Override
public void save(OutputStream out, String comments) {
- Properties props = new Properties();
- props.putAll(getter.get());
+ OrderedProperties props = new OrderedProperties(getter.get());
props.save(out, comments);
}
@Override
public void store(Writer writer, String comments) throws IOException {
- Properties props = new Properties();
- props.putAll(getter.get());
+ OrderedProperties props = new OrderedProperties(getter.get());
props.store(writer, comments);
}
@Override
public void store(OutputStream out, String comments) throws IOException {
- Properties props = new Properties();
- props.putAll(getter.get());
+ OrderedProperties props = new OrderedProperties(getter.get());
Review Comment:
The variable is neither returned or thrown, it does not apply here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]