slawekjaranowski commented on a change in pull request #499:
URL: https://github.com/apache/maven-surefire/pull/499#discussion_r835409879
##########
File path:
surefire-providers/surefire-junit4/src/main/java/org/apache/maven/surefire/junit4/JUnit4Provider.java
##########
@@ -432,7 +430,6 @@ private static boolean hasFilteredOutAllChildren(
Description description )
private Filter createMethodFilter()
{
- TestListResolver methodFilter = optionallyWildcardFilter( testResolver
);
- return methodFilter.isEmpty() || methodFilter.isWildcard() ? null :
new TestResolverFilter( methodFilter );
+ return testResolver != null && testResolver.hasMethodPatterns() ? new
TestResolverFilter( testResolver ) : null;
Review comment:
In expresion:
``` java
TestListResolver methodFilter = optionallyWildcardFilter(
testResolver );
return methodFilter.isEmpty() || methodFilter.isWildcard()
? null : new TestResolverFilter( methodFilter );
```
`methodFilter.isEmpty()` always return false
`methodFilter.isWildcard() != methodFilter.hasMethodPatterns()` is always
true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
