Tibor17 commented on a change in pull request #499:
URL: https://github.com/apache/maven-surefire/pull/499#discussion_r835318041
##########
File path:
surefire-api/src/test/java/org/apache/maven/surefire/api/testset/TestListResolverTest.java
##########
@@ -267,13 +270,16 @@ public void testShouldRunAny()
public void testClassFilter()
{
TestListResolver resolver = new TestListResolver( "#test" );
- assertTrue( resolver.shouldRun( "pkg/MyTest.class", null ) );
+ assertTrue( resolver.shouldRun( "pkg/MyTest.class", "test" ) );
Review comment:
It means that whatever class should run.
This verifies ParentRunner in JUnit4.
If you type `resolver.shouldRun( "pkg/Abc.class", "otherMethod" )`, it
returns false because it verifies the child of ParentRunner. Methods do not
match * = Abc but abc !=otherMethod
If shouldRun has null method then we compare classes => ParentRunner, and in
this case * matches Abc => true
If shouldRun has non-null method, we evaluate test method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
