slawekjaranowski commented on a change in pull request #499:
URL: https://github.com/apache/maven-surefire/pull/499#discussion_r835403846
##########
File path:
surefire-providers/surefire-junit4/src/main/java/org/apache/maven/surefire/junit4/JUnit4Provider.java
##########
@@ -432,7 +430,6 @@ private static boolean hasFilteredOutAllChildren(
Description description )
private Filter createMethodFilter()
{
- TestListResolver methodFilter = optionallyWildcardFilter( testResolver
);
- return methodFilter.isEmpty() || methodFilter.isWildcard() ? null :
new TestResolverFilter( methodFilter );
+ return testResolver != null && testResolver.hasMethodPatterns() ? new
TestResolverFilter( testResolver ) : null;
Review comment:
I removed `isWildcard` also ...
Test for master code:
```java
tlr = new TestListResolver( "*.class" );
assertTrue( tlr.isWildcard() );
assertFalse( tlr.hasMethodPatterns() );
tlr = new TestListResolver( "*#*" );
assertFalse( tlr.isWildcard() );
assertTrue( tlr.hasMethodPatterns() );
tlr = new TestListResolver( "**/*#*" );
assertFalse( tlr.isWildcard() );
assertTrue( tlr.hasMethodPatterns() );
```
`isWildicard()` return true only for `*.class`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
