Tibor17 commented on a change in pull request #499:
URL: https://github.com/apache/maven-surefire/pull/499#discussion_r835306825
##########
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/testset/TestListResolver.java
##########
@@ -135,27 +131,6 @@ public boolean hasMethodPatterns()
return hasIncludedMethodPatterns() || hasExcludedMethodPatterns();
}
- /**
- *
- * @param resolver filter possibly having method patterns
- * @return {@code resolver} if {@link TestListResolver#hasMethodPatterns()
resolver.hasMethodPatterns()}
- * returns {@code true}; Otherwise wildcard filter {@code *.class} is
returned.
- */
- public static TestListResolver optionallyWildcardFilter( TestListResolver
resolver )
- {
- return resolver.hasMethodPatterns() ? resolver : WILDCARD;
- }
-
- public static TestListResolver getEmptyTestListResolver()
- {
- return EMPTY;
- }
-
- public final boolean isWildcard()
Review comment:
This is still a valid case.
If TLR is empty (nothing) or a wildcard (everything), the provider would
ignore TLR. But both corner cases may happen in the config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
