slawekjaranowski commented on a change in pull request #499:
URL: https://github.com/apache/maven-surefire/pull/499#discussion_r835414115



##########
File path: 
surefire-api/src/main/java/org/apache/maven/surefire/api/testset/TestListResolver.java
##########
@@ -135,27 +131,6 @@ public boolean hasMethodPatterns()
         return hasIncludedMethodPatterns() || hasExcludedMethodPatterns();
     }
 
-    /**
-     *
-     * @param resolver    filter possibly having method patterns
-     * @return {@code resolver} if {@link TestListResolver#hasMethodPatterns() 
resolver.hasMethodPatterns()}
-     * returns {@code true}; Otherwise wildcard filter {@code *.class} is 
returned.
-     */
-    public static TestListResolver optionallyWildcardFilter( TestListResolver 
resolver )
-    {
-        return resolver.hasMethodPatterns() ? resolver : WILDCARD;
-    }
-
-    public static TestListResolver getEmptyTestListResolver()
-    {
-        return EMPTY;
-    }
-
-    public final boolean isWildcard()

Review comment:
       only one case is true for `isWildcard`:
   
   ```java
           tlr = new TestListResolver( "*.class" );
           assertTrue( tlr.isWildcard() );
   ```        




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to