easyice commented on PR #15104: URL: https://github.com/apache/lucene/pull/15104#issuecomment-3212734828
> So this is not testing mmapdir's implementation at all! > > https://github.com/apache/lucene/blob/6cfaa5ef831cb361909e32a621ac9ecc6514c7cc/lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/GroupVIntBenchmark.java#L187-L191 > > So actually we have no bechhmark and this shows why the performance trap with the lambda was never visible in any benchmark!? In my understand this PR will also fix this issue. In the main branch, `benchMMapDirectoryInputs_readGroupVInt` invokes readGroupVInt(DataInput, **long[]**, int), which bypasses `in.readGroupVInt` and therefore does not exercise the mmap code path. This PR updates `benchMMapDirectoryInputs_readGroupVInt` to call readGroupVInts(DataInput, **int[]**, int) instead, ensuring that the mmap code is covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
