uschindler commented on PR #15104: URL: https://github.com/apache/lucene/pull/15104#issuecomment-3211059341
OK, Thanks! Let's wait for Mike McCandeless benchmark too and let us see how this fixes the actual issue (slowdown) caused by GC pressure because of the Lambda. This may work well in this small benchamrk, but with call-site pollution it suddenly behaves much worse (due to the lambda). The biggest problem with this benchmark is: it does not does long enough warmup (therefore the optimizations required for MMap to be efficient won't appy) and it does not have the callsite pollution, because all benchs run with a separate JVM (that's what I get from the annotations). So it runs the mmap case too isolated and therefor the optimizer can remove the lambda completely. There may be a small slowdown in the highly optimized case we see here, because there's no cast of the referent. But this should go away with longer runtimes. I would only trust that benchmark if we made it use a more real workload. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
