uschindler commented on PR #15104: URL: https://github.com/apache/lucene/pull/15104#issuecomment-3214222626
> The speedup in nightly benchmarks is due to #15039 with very high likelihood. Much fewer virtual calls when computing scores and slightly better vectorization. Looks like this is correct, I needed to dig a bit and figure out if the PR was not already part of the old run of Aug 18th on Mike's server, but it looks like it was the "first" commit afetr the last successful run on Aug 18th: https://github.com/apache/lucene/compare/90be960a981d9cabe27f20f0781f735c48478de1...32e97a6f66157a98f35ba98d983ad0d5eb5de4b9 So I think this might be the reason. It is very bad that we had som many performance critical commits in that short time and failing benchmaerks at same time! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
