uschindler commented on PR #15104: URL: https://github.com/apache/lucene/pull/15104#issuecomment-3210864386
> cc @rmuir who made me find this bug by observing that naive decoding and optimized decoding performed the same > > @uschindler I'm not sure why but I'm getting much worse performance since #15089 (I get ~10.4 ops/us before this PR): > > ``` > Benchmark (size) Mode Cnt Score Error Units > GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVInt 64 thrpt 5 0.624 ± 0.010 ops/us > GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 6.833 ± 0.080 ops/us > GroupVIntBenchmark.benchMMapDirectoryInputs_readVInt 64 thrpt 5 8.976 ± 0.270 ops/us > ``` This cannot be correct, because the new code is actually having less indirections. And Roberts ran the same benchmark (and I also did), the results were not worse and actually more stable. The code is actually simpler (no lambda anymore), so it is strange what you see now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
