uschindler commented on PR #15104: URL: https://github.com/apache/lucene/pull/15104#issuecomment-3210951216
I think, the whole benchmark code should be rewritten and also make sure that the variable naming actually shows what is measured. How do your changes now alling with what we have seen 3 days ago? The MMap one was very noisy and wa snot noisy anmore (see in the #15089 issue). How can this be explained. I'd like to see a benchmark with much higher warmup time (it is also too short for VarHandles to inline correctly). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
