uschindler commented on code in PR #14942:
URL: https://github.com/apache/lucene/pull/14942#discussion_r2203404508
##########
gradle/validation/ast-grep/tests/java-patterns.yml:
##########
@@ -102,3 +102,15 @@ valid:
public abstract class X extends TokenizerFactory {}
- |
private class X extends TokenizerFactory {}
+---
+id: incubator-module-dependency
+invalid:
Review Comment:
Maybe add a check that it also triggers on import
##########
gradle/validation/forbidden-apis/non-standard/incubator-vector.txt:
##########
@@ -0,0 +1,20 @@
+# Some vector APIs are only fast on specific hardware, and fallback to very
slow
+# pure-java implementations. List them here, to prevent traps.
+
+@defaultMessage Potentially slow on some CPUs, please check
Constants.HAS_FAST_VECTOR_FMA: FMA may fallback to BigDecimal
+jdk.incubator.vector.Float16#fma(**)
+jdk.incubator.vector.FloatVector#fma(**)
+jdk.incubator.vector.DoubleVector#fma(**)
+jdk.incubator.vector.VectorOperators#FMA
+
+@defaultMessage Potentially slow on some CPUs, please check the CPU has
feature: Unsupported on NEON
Review Comment:
Maybe adapt message later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
