uschindler commented on PR #14942: URL: https://github.com/apache/lucene/pull/14942#issuecomment-3066972383
Robert, I added your signatures. The build fails now: ``` > Task :lucene:core:forbiddenApisMain24 FAILED Forbidden method invocation: jdk.incubator.vector.FloatVector#fma(**) [Potentially slow on some CPUs, please check the CPU has feature: FMA may fallback to BigDecimal] in org.apache.lucene.internal.vectorization.PanamaVectorUtilSupport (PanamaVectorUtilSupport.java:83) Scanned 21 class file(s) for forbidden API invocations (in 0.30s), 1 error(s). ``` All fine now. It is up to you now to add suppress and check code is faine. But I think it now behaves as we want it to behave: Only one place with FMA is reported which is a static method with a check already! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org