rmuir commented on code in PR #14942: URL: https://github.com/apache/lucene/pull/14942#discussion_r2203407014
########## gradle/validation/forbidden-apis/non-standard/incubator-vector.txt: ########## @@ -0,0 +1,20 @@ +# Some vector APIs are only fast on specific hardware, and fallback to very slow +# pure-java implementations. List them here, to prevent traps. + +@defaultMessage Potentially slow on some CPUs, please check Constants.HAS_FAST_VECTOR_FMA: FMA may fallback to BigDecimal +jdk.incubator.vector.Float16#fma(**) +jdk.incubator.vector.FloatVector#fma(**) +jdk.incubator.vector.DoubleVector#fma(**) +jdk.incubator.vector.VectorOperators#FMA + +@defaultMessage Potentially slow on some CPUs, please check the CPU has feature: Unsupported on NEON Review Comment: I think the message is ok for now: we don't yet have a field in Constants for this one, if you want to use the feature you'll need to add that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
