uschindler commented on PR #14942: URL: https://github.com/apache/lucene/pull/14942#issuecomment-3067015221
As mentioned in the othe rPR, we should still ad a "git grep" pattern to fail if anybody adds some `jdk.incubator.*` module import into any `module-info.java`: ``` $ git grep '\bjdk.incubator.' **/module-info.java ``` this creates no positives yet. I know sometimes some devs on PRs try to do that in the benchmark-jmh module, so I'd add this simple grep. This is best to prevent any incubator usage anywhere (and if not, forbiddenapis will do it anyways). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
