rmuir commented on code in PR #14942:
URL: https://github.com/apache/lucene/pull/14942#discussion_r2203406028
##########
gradle/validation/ast-grep/tests/java-patterns.yml:
##########
@@ -102,3 +102,15 @@ valid:
public abstract class X extends TokenizerFactory {}
- |
private class X extends TokenizerFactory {}
+---
+id: incubator-module-dependency
+invalid:
Review Comment:
It will work, but we can add a test, `scoped_identifier` is used anywhere
you have `x.y.z` identifiers in the grammar.
https://github.com/tree-sitter/tree-sitter-java/blob/488557612b44bde9c5e8c3011138992a8e500c90/grammar.js#L841-L847
https://github.com/tree-sitter/tree-sitter-java/blob/488557612b44bde9c5e8c3011138992a8e500c90/grammar.js#L1003-L1007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
