dsmiley commented on PR #14740: URL: https://github.com/apache/lucene/pull/14740#issuecomment-2992922097
I definitely disagree on this PR being rushed. You aren't a fan of it but that doesn't make it rushed. > Trying to apply such settings to ALL files of ALL types in repo is too much, you need to deal with wacky file types (e.g. make with tabs), windows file types that should have CRLF, generated files, test files, files that aren't valid utf-8, and the list goes on and on. I mostly sympathize. As you & Dawid suggested, I can remove the initial everything glob, and instead copy the rules there now to the files types it lists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
