msokolov commented on PR #14740: URL: https://github.com/apache/lucene/pull/14740#issuecomment-2988905484
This got me worried so I checked emacs editorconfig support https://www.gnu.org/software/emacs/manual/html_node/emacs/EditorConfig-support.html and it turns out it is off by default, phew. On Thursday, June 19th, 2025 at 2:47 PM, Robert Muir ***@***.***> wrote: > rmuir left a comment [(apache/lucene#14740)](https://github.com/apache/lucene/pull/14740#issuecomment-2988890817) > >> I think you're missing a point of the value of this. It's complementary with Spotless (or similar). It helps us write code formatted according to the project's standards during the writing/editing process, especially when utilizing IDE features that manipulate code (e.g. refactorings, perhaps code suggestion completions too). Consequently, forgetting to run tidy/Spotless can be less of an annoyance... pushing more formatting earlier. > > ***@***.***(https://github.com/dsmiley) .editorconfig has nothing to do with spotless or IDEs or anything like that. It configures editors... all editors. > > If affects us all, for all files: even those people not using an IDE. When this PR was merged my editor (vim) was throwing errors left and right! > > So I'd ask if we want to tweak intellij formatting, that if possible, we configure that intellij-specific stuff elsewhere in the project. > > This file is very important, will be interpreted by all kinds of editors (not just IDE) so its best to be on the minimal side and be extremely careful around it. > > — > Reply to this email directly, [view it on GitHub](https://github.com/apache/lucene/pull/14740#issuecomment-2988890817), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAHHUQNZFARPDXJTCLOPTKT3EMAULAVCNFSM6AAAAAB6KDRV72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOBYHA4TAOBRG4). > You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
