rmuir commented on PR #14740: URL: https://github.com/apache/lucene/pull/14740#issuecomment-2991984654
Personally I think there's just too much going on here. The file was rushed in too quickly and is far too aggressive (e.g. applying too many aggressive settings to ALL files). It is better to proceed with caution around this file. An example would be the python file deleted here: https://github.com/apache/lucene/blob/f83587416ecaa7b5fb201dd3938fd06e2af95aba/dev-tools/scripts/.editorconfig Because there was inconsistent formatting of the python files in that folder, it was introduced JUST for very specific filetype in JUST that specific folder. Trying to apply such settings to ALL files of ALL types in repo is too much, you need to deal with wacky file types (e.g. make with tabs), windows file types that should have CRLF, generated files, test files, files that aren't valid utf-8, and the list goes on and on. I'm trying to cope regardless, but it isn't easy and I still think there's too much going on here. See #14819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
