ChrisHegarty commented on PR #14275: URL: https://github.com/apache/lucene/pull/14275#issuecomment-2694804577
Yeah, I can see your point. What unsettles me a little about the proposed change is the "weight" that it imposes on this simple SPI interface for a somewhat niche issue. That said, there is currently no way to even ensure that the Lucene provider is the one that gets found. For example, in all my experiments in Elasticsearch, the ES provider has always been found. But I can see from the code that it is not always guaranteed to be. If we deployed on the classpath, then I'd just ensure the order there. So if this is not the right API point here, I do think that it is worth doing something here. For example, I did start to consider your previous suggestion - priority order, but need to rethink if there is something "lighter weight" that could be done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
