javanna commented on PR #14275: URL: https://github.com/apache/lucene/pull/14275#issuecomment-2711741530
> But I'm still questioning if there's actually a use-case for allowing something to be loaded either on-heap or off-heap in our codecs. For all examples that come to mind, I would rather like Lucene to make the call than give users the option. In the case of the completion postings format, maybe we should just always load the FST off-heap? I see where you are going, this would be pragmatic, but I wonder next what happens if anyone would like to switch that back to on-heap, I don't know how common that would be, but I still feel like it is odd to require maintaining a custom codec only to affect the loading. I guess I need to see how much complexity the solution we discussed above requires adding, because that matters too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
