jpountz commented on PR #14275: URL: https://github.com/apache/lucene/pull/14275#issuecomment-2714778925
> I do think that this is more generally useful, than just the particular use case of on or off -heap FST in completion postings. I'm curious of what other use-cases you have in mind. For reference, we used to allow configuring whether to load the FST on or off-heap for the terms index before we removed the option in Lucene 8.5 https://github.com/apache/lucene/commit/97336434661cf32f4674ddb43901219f678e2608#diff-53b0b5ab08e5c5c74639ced26c691039d2cf91dd2f5e4b3e065eaa1a1e6a9108. Before that, there were concerns that doc values (off-heap) would be slower than FieldCache (on-heap) but nowadays, nobody would suggest going back to FieldCache or loading doc values on heap, even just as an opt-in. Likewise, even though page faults are challenging with KNN vectors, nobody is suggesting that they should be loaded on-heap rather than off-heap. Why do we think that completion fields are different and should support being loaded on-heap? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
