jpountz commented on PR #14275: URL: https://github.com/apache/lucene/pull/14275#issuecomment-2710617442
> @jpountz given the connection of this PR with completion FST, do you have opinions here? Sorry for the late reply. If we want to allow configuring how a codec gets loaded at read time, I agree with @uschindler 's suggestion of doing it via options passed to `DirectoryReader#load`. But I'm still questioning if there's actually a use-case for allowing something to be loaded either on-heap or off-heap in our codecs. For all examples that come to mind, I would rather like Lucene to make the call than give users the option. In the case of the completion postings format, maybe we should just always load the FST off-heap? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
