javanna commented on PR #14270: URL: https://github.com/apache/lucene/pull/14270#issuecomment-2685272175
I think that we do we need to have a way to truly make the switch at least for testing purposes, otherwise we only test one approach which is error prone. That's the original issue that this PR addresses From a users perspective, I don't have data at hand to show that off-heap is as performant as on heap. Given how difficult it's been to use off heap completion fields, I'd assume that everyone always relied on on-heap, as that has been the default since day one years ago. I think exposing a way to make the switch would be handy. I personally find it not so user-friendly to require users to define their own codec only for loading purposes, when there is no effect on how stuff is written. Is that a common thing users may do in other scenarios like inverted indices, doc values etc. ? If you are suggesting switching to off-heap by default, I am +1 for that. FYI, another problem we have around providing custom completion postings formats is going to be addressed by #14275, so that existing SPI services can be predictably replaced. Once that is fixed, either changing the default or requiring users to provide their own postings format to override the default behaviour is probably good enough. In that case I would leave the static handling I am adding in this PR only for testing purposes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
