javanna commented on code in PR #14270:
URL: https://github.com/apache/lucene/pull/14270#discussion_r1965567430
##########
lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java:
##########
@@ -949,10 +952,7 @@ static IndexWriterConfig iwcWithSuggestField(Analyzer
analyzer, final Set<String
iwc.setMergePolicy(newLogMergePolicy());
Codec filterCodec =
new FilterCodec(TestUtil.getDefaultCodec().getName(),
TestUtil.getDefaultCodec()) {
- final CompletionPostingsFormat.FSTLoadMode fstLoadMode =
- RandomPicks.randomFrom(random(),
CompletionPostingsFormat.FSTLoadMode.values());
- final PostingsFormat postingsFormat = new
Completion101PostingsFormat(fstLoadMode);
Review Comment:
While this looked like randomizing the load mode, it did not as SPI would
not go through this constructor. Setting fst load mode this way would take no
effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
