javanna opened a new pull request, #14270: URL: https://github.com/apache/lucene/pull/14270
We currently have a gap in testing the completion postings format. While it allows to load FSTs off heap, and the format has a constructor that takes the fst load mode, at read time SPI goes through the default constructor that has fst load mode hardcoded to on heap at all times. This means that despite we randomize fst load mode in `TestSuggestField`, we never effectively load the completion FST off heap, we only set the load mode to something different than on heap when writing, where the load mode takes no effect. This commit introduces a static method that allows to switch the loading of the FST for all the completion postings format. This unveils a bug when loading FST off heap and the index input is a `MemorySegmentIndexInput` which I am going a PR for separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
