javanna commented on code in PR #14270:
URL: https://github.com/apache/lucene/pull/14270#discussion_r1965557931


##########
lucene/suggest/src/java/org/apache/lucene/search/suggest/document/Completion101PostingsFormat.java:
##########
@@ -25,17 +25,10 @@
  * @lucene.experimental
  */
 public class Completion101PostingsFormat extends CompletionPostingsFormat {
-  /** Creates a {@link Completion101PostingsFormat} that will load the 
completion FST on-heap. */
-  public Completion101PostingsFormat() {
-    this(FSTLoadMode.ON_HEAP);

Review Comment:
   This is the constructor called by SPI when reading, and it has on heap 
hardcoded.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to