rmuir commented on PR #14193: URL: https://github.com/apache/lucene/pull/14193#issuecomment-2638840849
I'm feeling good about this one now, with the change, a lot of regexps now come out minimal from the start, which is a good thing. We also eliminate overhead of tons of nodes, which is important if we ever want to support caseless range matches (e.g. `[a-z]` with case-insensitive flag matching 'A'). To implement it generally (not just for ascii), we need to iterate the range and add tons of alternatives, but its an `int[]` and will all be folded into a single state: basically as good as we can get. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
