rmuir commented on code in PR #14193:
URL: https://github.com/apache/lucene/pull/14193#discussion_r1943651732
##########
lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java:
##########
@@ -648,13 +645,16 @@ private Automaton toAutomaton(
break;
case REGEXP_CHAR:
if (check(ASCII_CASE_INSENSITIVE)) {
- a = toCaseInsensitiveChar(c);
+ a = Automata.makeCharSet(toCaseInsensitiveChar(c));
} else {
a = Automata.makeChar(c);
}
break;
case REGEXP_CHAR_RANGE:
- a = Automata.makeCharRange(from, to);
+ a = Automata.makeCharRange(from[0], to[0]);
Review Comment:
I can clean this up. We could actually remove this node (and others)
completely if we wanted. It will help, lemme look again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
