Re: [PR] Add Automata.makeCharSet/makeCharClass to optimize regexp [lucene]

[via GitHub]

dweiss commented on PR #14193:
URL: https://github.com/apache/lucene/pull/14193#issuecomment-2640330745

   > Finally! The concatenate() issue was an easy fix, it neglected to clean up 
its dead states. All of its partners in crime do this, but the fact we neglect 
it for concatenate messes up too many As.
   > 
   > ![Screen_Shot_2025-02-05_at_23 55 
55](https://private-user-images.githubusercontent.com/504194/410297736-f5b5234c-73cd-4431-abed-6f39023eb687.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NTk0NjQsIm5iZiI6MTczODg1OTE2NCwicGF0aCI6Ii81MDQxOTQvNDEwMjk3NzM2LWY1YjUyMzRjLTczY2QtNDQzMS1hYmVkLTZmMzkwMjNlYjY4Ny5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNlQxNjI2MDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lNWZhYjljM2Q2YzlkMjBjNWYyMDMzNDkxMjQwN2ZjMDE1MGFhYzgxYmFmODMwM2VjNTE4ZWMwZWE1ODJlMDlhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Rh69pJtLL-XnnnprIgmM_nlBl6KxABbd2lRpcg0kdAU)
   
   God this is so much nicer compared to that first/ original automaton you 
included!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org