rmuir commented on code in PR #14193:
URL: https://github.com/apache/lucene/pull/14193#discussion_r1944084497
##########
lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java:
##########
@@ -648,13 +645,16 @@ private Automaton toAutomaton(
break;
case REGEXP_CHAR:
if (check(ASCII_CASE_INSENSITIVE)) {
- a = toCaseInsensitiveChar(c);
+ a = Automata.makeCharSet(toCaseInsensitiveChar(c));
} else {
a = Automata.makeChar(c);
}
break;
case REGEXP_CHAR_RANGE:
- a = Automata.makeCharRange(from, to);
+ a = Automata.makeCharRange(from[0], to[0]);
Review Comment:
I looked. toString is a problem. so I want to leave this one be for now. To
me it also doesn't make sense to keep adding more "variables" to the RegExp
class , it has too many already for these nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
