rmuir commented on code in PR #14193:
URL: https://github.com/apache/lucene/pull/14193#discussion_r1943653718
##########
lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java:
##########
@@ -1050,14 +1059,25 @@ static RegExp makeDeprecatedComplement(int flags,
RegExp exp) {
}
static RegExp makeChar(int flags, int c) {
- return newLeafNode(flags, Kind.REGEXP_CHAR, null, c, 0, 0, 0, 0, 0);
+ return newLeafNode(flags, Kind.REGEXP_CHAR, null, c, 0, 0, 0, null, null);
}
static RegExp makeCharRange(int flags, int from, int to) {
if (from > to)
throw new IllegalArgumentException(
"invalid range: from (" + from + ") cannot be > to (" + to + ")");
- return newLeafNode(flags, Kind.REGEXP_CHAR_RANGE, null, 0, 0, 0, 0, from,
to);
+ return newLeafNode(
+ flags, Kind.REGEXP_CHAR_RANGE, null, 0, 0, 0, 0, new int[] {from}, new
int[] {to});
Review Comment:
yeah it is. The only reason I didn't nuke these RANGE and CHAR nodes is ...
toString()!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
