cpoerschke commented on code in PR #13635: URL: https://github.com/apache/lucene/pull/13635#discussion_r1778218742
########## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ########## @@ -156,6 +196,55 @@ private TopDocs getLeafResults( } } + private DocIdSetIterator executeSeedQuery(LeafReaderContext ctx, Weight seedWeight) + throws IOException { + if (seedWeight != null) { Review Comment: minor/subjective: return on null and then one less 'indentation level' for remainder of the method implementation ```suggestion if (seedWeight == null) return null; ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org