cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778436381
##########
lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java:
##########
@@ -156,6 +196,55 @@ private TopDocs getLeafResults(
}
}
+ private DocIdSetIterator executeSeedQuery(LeafReaderContext ctx, Weight
seedWeight)
+ throws IOException {
+ if (seedWeight != null) {
+ // Execute the seed query
+ TopScoreDocCollector seedCollector =
+ new TopScoreDocCollectorManager(
+ k /* numHits */,
+ null /* after */,
+ Integer.MAX_VALUE /* totalHitsThreshold */,
+ false /* supportsConcurrency */)
+ .newCollector();
+ LeafCollector leafCollector;
+ try {
+ leafCollector = seedCollector.getLeafCollector(ctx);
Review Comment:
sorry, i think i got this suggestion wrong, `leafCollector.finish()` needs
to be called even if an exception was caught and as such the declaration needs
to be outside the `try-catch` block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
