cpoerschke commented on code in PR #13635: URL: https://github.com/apache/lucene/pull/13635#discussion_r1778283453
########## lucene/test-framework/src/java/org/apache/lucene/tests/index/MismatchedLeafReader.java: ########## @@ -68,6 +71,28 @@ public CacheHelper getReaderCacheHelper() { return in.getReaderCacheHelper(); } + @Override + public void searchNearestVectors( + String field, + float[] target, + KnnCollector knnCollector, + Bits acceptDocs, + DocIdSetIterator seedDocs) + throws IOException { + in.searchNearestVectors(field, target, knnCollector, acceptDocs, seedDocs); + } + + @Override + public void searchNearestVectors( + String field, + byte[] target, + KnnCollector knnCollector, + Bits acceptDocs, + DocIdSetIterator seedDocs) + throws IOException { + in.searchNearestVectors(field, target, knnCollector, acceptDocs, seedDocs); + } + Review Comment: Might not be necessary if/since `FilterLeafReader.java` has the implementation. ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org