cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778463376
##########
lucene/core/src/test/org/apache/lucene/document/TestManyKnnDocs.java:
##########
@@ -46,27 +54,139 @@ public void testLargeSegment() throws Exception {
mp.setMaxMergeAtOnce(256); // avoid intermediate merges (waste of time
with HNSW?)
mp.setSegmentsPerTier(256); // only merge once at the end when we ask
iwc.setMergePolicy(mp);
- String fieldName = "field";
- VectorSimilarityFunction similarityFunction =
VectorSimilarityFunction.DOT_PRODUCT;
+ VectorSimilarityFunction similarityFunction =
VectorSimilarityFunction.EUCLIDEAN;
Review Comment:
Could we retain use of existing similarity function? And if alternative is
needed perhaps have that for an additional field?
```suggestion
VectorSimilarityFunction similarityFunction =
VectorSimilarityFunction.DOT_PRODUCT;
```
##########
lucene/core/src/test/org/apache/lucene/document/TestManyKnnDocs.java:
##########
@@ -46,27 +54,139 @@ public void testLargeSegment() throws Exception {
mp.setMaxMergeAtOnce(256); // avoid intermediate merges (waste of time
with HNSW?)
mp.setSegmentsPerTier(256); // only merge once at the end when we ask
iwc.setMergePolicy(mp);
- String fieldName = "field";
- VectorSimilarityFunction similarityFunction =
VectorSimilarityFunction.DOT_PRODUCT;
Review Comment:
Could we retain use of existing similarity function? And if alternative is
needed perhaps have that for an additional field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
