seanmacavaney commented on PR #13635: URL: https://github.com/apache/lucene/pull/13635#issuecomment-2376566988
Thanks @benwtrent! > One thing that still bugs me is attaching yet another parameter to a common method. Especially a parameter that will be rarely used (my gut reaction is choosing the correct seed query is difficult and average users will never use it). I will think more about this. Maybe its just fine and I am overreacting. That's a fair point. What might be the alternative that doesn't affect the main `LeafReader.searchNearestVectors` methods? Perhaps a private member with a getter/setter? > I like this idea. Do you have any scripts & test data where you have tested that this Lucene implementation works and gives as good as results as you had in the original paper? I've tested it on some internal datasets and it's performed favorably, albeit not quite as strong as the original paper. (This is likely due to both differences in the distribution of the data and implementation differences, especially around the efficiency of lexical search.) Automated tests in the suite test that it's functioning as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
