gsmiller commented on code in PR #13636: URL: https://github.com/apache/lucene/pull/13636#discussion_r1707451406
########## lucene/core/src/java/org/apache/lucene/internal/vectorization/DefaultPostingDecodingUtil.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.internal.vectorization; + +import java.io.IOException; +import org.apache.lucene.store.IndexInput; + +final class DefaultPostingDecodingUtil extends PostingDecodingUtil { + + protected final IndexInput in; + + public DefaultPostingDecodingUtil(IndexInput in) { + this.in = in; + } + + @Override + public void splitLongs(int count, long[] b, int bShift, long bMask, long[] c, long cMask) + throws IOException { + assert count <= 64; + in.readLongs(c, 0, count); + // The below loop is auto-vectorized + for (int i = 0; i < count; ++i) { + b[i] = (c[i] >>> bShift) & bMask; + c[i] &= cMask; Review Comment: If I'm understanding things correctly, we only need to apply this masking for some of the BPV values but not all. For example, we don't need this masking step for bpv4 but we do need it for bpv12. Our current code is selective about when it does this but it looks like here we're going be always doing it, which creates some wasted overhead. I wonder if there's an opportunity to do this selectively? Or maybe it doesn't actually matter in practice? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
