uschindler commented on code in PR #13636:
URL: https://github.com/apache/lucene/pull/13636#discussion_r1707463821
##########
lucene/core/src/java21/org/apache/lucene/internal/vectorization/PanamaVectorizationProvider.java:
##########
@@ -79,4 +102,18 @@ public VectorUtilSupport getVectorUtilSupport() {
public FlatVectorsScorer getLucene99FlatVectorsScorer() {
return Lucene99MemorySegmentFlatVectorsScorer.INSTANCE;
}
+
+ @Override
+ public PostingDecodingUtil getPostingDecodingUtil(IndexInput input) throws
IOException {
Review Comment:
I would do the fast integer vectors check here and return default if not
supported.
I'd rename this method to have "new" in its name, like said before. The
returned instance is a new one with some kind of state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
